Add -Z skip-end-regions as way to side-step EndRegion emission.#44219
Closed
pnkfelix wants to merge 1 commit intorust-lang:masterfrom
Closed
Add -Z skip-end-regions as way to side-step EndRegion emission.#44219pnkfelix wants to merge 1 commit intorust-lang:masterfrom
-Z skip-end-regions as way to side-step EndRegion emission.#44219pnkfelix wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
arielb1
reviewed
Aug 31, 2017
Contributor
There was a problem hiding this comment.
Can't you pass the tcx here instead of using TLS? Using TLS like that is kind of an anti-pattern.
Contributor
Author
There was a problem hiding this comment.
I thought I considered this and rejected it (based on a fear of having to thread tcx up a long method chain), but looking at it now I don't know why I came to that conclusion, since the Builder in scope.rs carries a hair::cx::Cx...
Will fix.
The main intent is to investigate cases where EndRegion emission is believed to be causing excess peak memory pressure. It may also be of use to people inspecting the MIR output who find the EndRegions to be a distraction. ---- (commit is now updated to thread the tcx down instead of consulting thread-local storage for it.)
pnkfelix
force-pushed
the
debugflag-skip-end-regions
branch
from
cd27c30 to
051601e
Compare
Contributor
Author
|
Closing in favor of #44249 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-Z skip-end-regionsas way to side-step EndRegion emission.The main intent is to investigate cases where EndRegion emission is believed to be causing excess peak memory pressure.
It may also be of use to people inspecting the MIR output who find the EndRegions to be a distraction.