Skip to content

Document how lock 'guard' structures are created.#38010

Merged
bors merged 3 commits intorust-lang:masterfrom
frewsxcv:lock-creations
Nov 26, 2016
Merged

Document how lock 'guard' structures are created.#38010
bors merged 3 commits intorust-lang:masterfrom
frewsxcv:lock-creations

Conversation

@frewsxcv
Copy link
Copy Markdown
Contributor

@frewsxcv frewsxcv commented Nov 25, 2016

No description provided.

@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 25, 2016

r? @GuillaumeGomez

@rust-highfive
Copy link
Copy Markdown
Contributor

rust-highfive commented Nov 25, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez
GuillaumeGomez reviewed Nov 25, 2016
View reviewed changes
Comment thread src/libstd/sync/mutex.rs Outdated
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not PR-bound but shouldn't be a dot present a the end of this sentence?

GuillaumeGomez
GuillaumeGomez requested changes Nov 25, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit and it's good.

Comment thread src/libstd/sync/rwlock.rs Outdated
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace in "[read()] and".

@frewsxcv
Copy link
Copy Markdown
Contributor Author

frewsxcv commented Nov 25, 2016

Comments have been addressed.

@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Nov 26, 2016

Now squash time! \o/ (just the last commit)

@frewsxcv
Document how the MutexGuard structure is created.
6075af4 
Also, end sentence with a period.
@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Nov 26, 2016

Thanks!

@bors: r+ rollup

@bors
Copy link
Copy Markdown
Collaborator

bors commented Nov 26, 2016

📌 Commit 6075af4 has been approved by GuillaumeGomez

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Nov 26, 2016
@sanxiyn
Rollup merge of rust-lang#38010 - frewsxcv:lock-creations, r=Guillaum…
44b926a 
…eGomez

Document how lock 'guard' structures are created.
@sanxiyn sanxiyn mentioned this pull request Nov 26, 2016
Merged
bors added a commit that referenced this pull request Nov 26, 2016
@bors
Auto merge of #38015 - sanxiyn:rollup, r=sanxiyn
7e39c0e 
Rollup of 7 pull requests

- Successful merges: #37962, #37963, #37967, #37978, #37985, #38001, #38010
- Failed merges:
@bors bors merged commit 6075af4 into rust-lang:master Nov 26, 2016
@frewsxcv frewsxcv deleted the lock-creations branch December 4, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv @rust-highfive @GuillaumeGomez @bors @sfackler