Fix "consider removing this semicolon" help#32710
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 5, 2016
jonas-schievink:consider-last-semi
Merged
Fix "consider removing this semicolon" help#32710bors merged 2 commits intorust-lang:masterfrom jonas-schievink:consider-last-semi
bors merged 2 commits intorust-lang:masterfrom
jonas-schievink:consider-last-semi
Conversation
Check last statement in a block, not the first
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
Somewhat related #21838 |
| fn f() -> String { //~ ERROR E0269 | ||
| //~^ HELP detailed explanation | ||
| 0u8; | ||
| "bla".to_string(); //~ HELP consider removing this semicolon |
Member
There was a problem hiding this comment.
Could you also add a test like the one in the linked playpen too?
Member
|
r=me with a requested test |
Contributor
Author
|
Done! |
Member
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 5, 2016
… r=nagisa Fix "consider removing this semicolon" help Check last statement in a block, not the first. Example of current weirdness: http://is.gd/w80J9h The help was only rarely emitted, and if so, often incorrectly (see above playpen). It was basically only useful with single-statement functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check last statement in a block, not the first.
Example of current weirdness: http://is.gd/w80J9h
The help was only rarely emitted, and if so, often incorrectly (see above playpen). It was basically only useful with single-statement functions.