Nomicon: wrong type in Vec deallocation example#30735
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 7, 2016
jtepe:nomicon_vec_dealloc_pointer_type
Merged
Nomicon: wrong type in Vec deallocation example#30735bors merged 1 commit intorust-lang:masterfrom jtepe:nomicon_vec_dealloc_pointer_type
bors merged 1 commit intorust-lang:masterfrom
jtepe:nomicon_vec_dealloc_pointer_type
Conversation
…nal code is correct, the example here would not compile without the cast. I used *mut _ instead of *mut u8 to be consistent with the final code.
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Author
|
r? @gankro |
Contributor
|
@bors: r+ rollup Thank you! |
Collaborator
|
📌 Commit eb30c66 has been approved by |
Contributor
|
💖 |
Author
|
😊 |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 6, 2016
…er_type, r=steveklabnik heap::deallocate expects a *mut u8, but here a *mut T is given as the type of the argument. This would not compile. The final code is correct, however.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
heap::deallocate expects a *mut u8, but here a *mut T is given as the type of the argument. This would not compile. The final code is correct, however.