Skip to content

Add correct use for Error and io#30712

Merged
bors merged 2 commits intorust-lang:masterfrom
lawrencewoodman:patch-3
Jan 15, 2016
Merged

Add correct use for Error and io#30712
bors merged 2 commits intorust-lang:masterfrom
lawrencewoodman:patch-3

Conversation

@lawrencewoodman
Copy link
Copy Markdown
Contributor

This also repeats the case analysis used.

This also repeated the case analysis used.
@rust-highfive
Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Copy Markdown
Member

r? @BurntSushi

@BurntSushi
Copy link
Copy Markdown
Member

@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 5, 2016

📌 Commit ca1f0c9 has been approved by BurntSushi

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 5, 2016

⌛ Testing commit ca1f0c9 with merge 7d80fb4...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 5, 2016

💔 Test failed - auto-linux-64-nopt-t

@Manishearth
Copy link
Copy Markdown
Member

@bors retry rollup

Comment thread src/doc/book/error-handling.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
@steveklabnik
Copy link
Copy Markdown
Contributor

@bors: retry

@steveklabnik
Copy link
Copy Markdown
Contributor

err actually new commit

@bors: r+ rollup

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jan 14, 2016

📌 Commit 0ca33ad has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
…bnik

This also repeats the case analysis used.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
…bnik

This also repeats the case analysis used.
bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit 0ca33ad into rust-lang:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants