Rc: Add assumptions that the pointer is non-null#21894
Merged
Merged
Conversation
Since the snapshot compiler is still using an older LLVM version, omit the call in stage0, because compile times explode otherwise.
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Member
|
@bors: rollup- |
Collaborator
|
⌛ Testing commit 40b6e34 with merge 7643521... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Contributor
Author
|
I can't reproduce this error, any hints? |
Member
|
Let's see if retrying with bors gives a hint! @bors: retry |
bors
added a commit
that referenced
this pull request
Feb 5, 2015
This is half of what @Aatch implemented in #21418. The non-null assumption is later canonicalized to !nonnull metadata and doesn't cause any slowdowns (in fact the build is slightly faster with this change). I left out the other half of #21418 because that still causes a ~16% increase in compile times (30m -> 35m).
Collaborator
Collaborator
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Mar 30, 2026
minor: Bump GitHub actions
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Apr 6, 2026
minor: Bump GitHub actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is half of what @Aatch implemented in #21418. The non-null assumption is later canonicalized to !nonnull metadata and doesn't cause any slowdowns (in fact the build is slightly faster with this change). I left out the other half of #21418 because that still causes a ~16% increase in compile times (30m -> 35m).