[WIP] Benchmarking for the parallel import resolution PR #158845#159387
Closed
petrochenkov wants to merge 1 commit into
Closed
[WIP] Benchmarking for the parallel import resolution PR #158845#159387petrochenkov wants to merge 1 commit into
petrochenkov wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
[WIP] Benchmarking for the parallel import resolution PR #158845
petrochenkov
removed
the
S-waiting-on-review
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (13552f1): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -8.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.85s -> 489.443s (-0.08%) |
rustbot
removed
the
S-waiting-on-perf
LorrensP-2158466
added a commit
to LorrensP-2158466/rust
that referenced
this pull request
Jul 17, 2026
…par_slice`. Currently it is all still single threaded, but almost everything needed to make the loop use multithreaded code is done in this commit. For performance reasons we do the resolution now in place instead of recollecting the indeterminate imports ([see benchmark pr](rust-lang#159387) and pr of this commit). With the accompanying changes to make datastructures concurrent: - populating external resolution tables now use `Once` to ensure only 1 thread builds the table and all others wait if they need it - implement `DynSync`/`DynSend` for `RefOrMut` and `CmCell` so it is allowed to use the `par_slice` function. `Cache(Ref)Cells` are not tackled yet because they are not needed here (and require extra work).
LorrensP-2158466
added a commit
to LorrensP-2158466/rust
that referenced
this pull request
Jul 17, 2026
…par_slice`. Currently it is all still single threaded, but almost everything needed to make the loop use multithreaded code is done in this commit. For performance reasons we do the resolution now in place instead of recollecting the indeterminate imports ([see benchmark pr](rust-lang#159387) and pr of this commit). With the accompanying changes to make datastructures concurrent: - populating external resolution tables now use `Once` to ensure only 1 thread builds the table and all others wait if they need it - implement `DynSync`/`DynSend` for `RefOrMut` and `CmCell` so it is allowed to use the `par_slice` function. `Cache(Ref)Cells` are not tackled yet because they are not needed here (and require extra work).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now this is #158845, but without migrating from
(Ref)Cells toRwLocks.