Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/rustc_resolve/src/diagnostics/impls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
self.tcx.dcx()
}

pub(crate) fn report_errors(&mut self, krate: &Crate) {
pub(crate) fn report_errors(&mut self, krate: &Crate, use_injections: Vec<UseError<'tcx>>) {
self.report_delayed_vis_resolution_errors();
self.report_with_use_injections(krate);
self.report_with_use_injections(krate, use_injections);

for &(span_use, span_def) in &self.macro_expanded_macro_export_errors {
self.lint_buffer.buffer_lint(
Expand Down Expand Up @@ -391,9 +391,9 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
}
}

fn report_with_use_injections(&mut self, krate: &Crate) {
fn report_with_use_injections(&mut self, krate: &Crate, use_injections: Vec<UseError<'tcx>>) {
for UseError { mut err, candidates, node_id, instead, suggestion, path, is_call } in
mem::take(&mut self.use_injections)
use_injections
{
let (span, found_use) = if node_id != DUMMY_NODE_ID {
UsePlacementFinder::check(krate, node_id)
Expand Down
19 changes: 14 additions & 5 deletions compiler/rustc_resolve/src/late.rs
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,9 @@ struct LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {

/// Count the number of places a lifetime is used.
lifetime_uses: FxHashMap<LocalDefId, LifetimeUseSet>,

/// `use` injections are delayed for better placement and deduplication.
use_injections: Vec<UseError<'tcx>>,
}

impl<'ra, 'tcx> AsRef<Resolver<'ra, 'tcx>> for LateResolutionVisitor<'_, '_, 'ra, 'tcx> {
Expand Down Expand Up @@ -1544,6 +1547,7 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
// errors at module scope should always be reported
in_func_body: false,
lifetime_uses: Default::default(),
use_injections: Vec::new(),
}
}

Expand Down Expand Up @@ -4624,7 +4628,7 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
is_call: source.is_call(),
};

this.r.use_injections.push(ue);
this.use_injections.push(ue);
}

PartialRes::new(Res::Err)
Expand Down Expand Up @@ -4728,7 +4732,7 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
}
} else {
// If there are suggested imports, the error reporting is delayed
this.r.use_injections.push(UseError {
this.use_injections.push(UseError {
err,
candidates,
node_id,
Expand Down Expand Up @@ -5701,7 +5705,10 @@ impl<'ast> Visitor<'ast> for ItemInfoCollector<'_, 'ast, '_, '_> {

impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
/// Returns the `use` and `extern crate` items of the crate, for use by `check_unused`.
pub(crate) fn late_resolve_crate<'ast>(&mut self, krate: &'ast Crate) -> Vec<&'ast Item> {
pub(crate) fn late_resolve_crate<'ast>(
&mut self,
krate: &'ast Crate,
) -> (Vec<&'ast Item>, Vec<UseError<'tcx>>) {
with_owner(self, CRATE_NODE_ID, |this| {
let mut info_collector = ItemInfoCollector { r: this, use_items: Vec::new() };
visit::walk_crate(&mut info_collector, krate);
Expand All @@ -5710,15 +5717,17 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
late_resolution_visitor
.resolve_doc_links(&krate.attrs, MaybeExported::Ok(CRATE_NODE_ID));
visit::walk_crate(&mut late_resolution_visitor, krate);
for (id, span) in late_resolution_visitor.diag_metadata.unused_labels.iter() {
let LateResolutionVisitor { use_injections, diag_metadata, .. } =
late_resolution_visitor;
for (id, span) in diag_metadata.unused_labels.iter() {
this.lint_buffer.buffer_lint(
lint::builtin::UNUSED_LABELS,
*id,
*span,
crate::diagnostics::UnusedLabel,
);
}
use_items
(use_items, use_injections)
})
}
}
Expand Down
8 changes: 4 additions & 4 deletions compiler/rustc_resolve/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1382,8 +1382,6 @@ pub struct Resolver<'ra, 'tcx> {
/// Ambiguity errors are delayed for deduplication.
ambiguity_errors: Vec<AmbiguityError<'ra>> = Vec::new(),
issue_145575_hack_applied: bool = false,
/// `use` injections are delayed for better placement and deduplication.
use_injections: Vec<UseError<'tcx>> = Vec::new(),
/// Visibility path resolution failures are delayed until all modules are collected.
delayed_vis_resolution_errors: Vec<DelayedVisResolutionError<'ra>> = Vec::new(),
/// Crate-local macro expanded `macro_export` referred to by a module-relative path.
Expand Down Expand Up @@ -2052,11 +2050,13 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
self.tcx
.sess
.time("finalize_macro_resolutions", || self.finalize_macro_resolutions(krate));
let use_items =
let (use_items, use_injections) =
self.tcx.sess.time("late_resolve_crate", || self.late_resolve_crate(krate));
self.tcx.sess.time("resolve_main", || self.resolve_main());
self.tcx.sess.time("resolve_check_unused", || self.check_unused(use_items));
self.tcx.sess.time("resolve_report_errors", || self.report_errors(krate));
self.tcx
.sess
.time("resolve_report_errors", || self.report_errors(krate, use_injections));
self.tcx
.sess
.time("resolve_postprocess", || self.cstore_mut().postprocess(self.tcx, krate));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ pub(crate) fn target() -> Target {
base.stack_probes = StackProbeType::Inline;
base.supported_sanitizers = SanitizerSet::ADDRESS
| SanitizerSet::CFI
| SanitizerSet::HWADDRESS
| SanitizerSet::LEAK
| SanitizerSet::SHADOWCALLSTACK;
base.default_sanitizers = SanitizerSet::SHADOWCALLSTACK;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ pub(crate) fn target() -> Target {
base.llvm_abiname = LlvmAbi::Lp64d;
base.max_atomic_width = Some(64);
base.stack_probes = StackProbeType::Inline;
base.supported_sanitizers = SanitizerSet::ADDRESS | SanitizerSet::SHADOWCALLSTACK;
base.supported_sanitizers = SanitizerSet::ADDRESS
| SanitizerSet::CFI
| SanitizerSet::LEAK
| SanitizerSet::SHADOWCALLSTACK;
base.default_sanitizers = SanitizerSet::SHADOWCALLSTACK;
base.supports_xray = true;

Expand Down
Loading