Skip to content

Resolver: extract use_injections out of main Resolver#159339

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
LorrensP-2158466:extract-use-injections
Jul 16, 2026
Merged

Resolver: extract use_injections out of main Resolver#159339
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
LorrensP-2158466:extract-use-injections

Conversation

@LorrensP-2158466

@LorrensP-2158466 LorrensP-2158466 commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Prep work for #158845. Extract the use_injections field out of the resolver and into the LateResolutionVisitor. It can then be passed into the report_errors pass, so no behaviour is changed.

This allows the Resolver to be DynSync, see #158845 (comment).

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 15, 2026
@rustbot

rustbot commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

@rustbot rustbot assigned petrochenkov and unassigned eholk Jul 15, 2026
@petrochenkov

petrochenkov commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7c8a29e has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 16, 2026
@jhpratt
Rollup merge of rust-lang#159339 - LorrensP-2158466:extract-use-injec…
7dbdec6 
…tions, r=petrochenkov

Resolver: extract `use_injections` out of main `Resolver`

Prep work for rust-lang#158845. Extract the `use_injections` field out of the resolver and into the `LateResolutionVisitor`. It can then be passed into the `report_errors` pass, so no behaviour is changed.

This allows the `Resolver` to be `DynSync`, see rust-lang#158845 (comment).

r? @petrochenkov
This was referenced Jul 16, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 16, 2026
@bors
Auto merge of #159367 - jhpratt:rollup-m6CJJYQ, r=jhpratt
d62fb1c 
Rollup of 3 pull requests

Successful merges:

 - #159028 (fuchsia: Ensure all existing ported sanitizers for Fuchsia are supported)
 - #159339 (Resolver: extract `use_injections` out of main `Resolver`)
 - #159342 (renovate: group github actions updates)
@rust-bors
rust-bors Bot merged commit 09be986 into rust-lang:main Jul 16, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 16, 2026
rust-timer added a commit that referenced this pull request Jul 16, 2026
@rust-timer
Unrolled build for #159339
2959eef 
Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov

Resolver: extract `use_injections` out of main `Resolver`

Prep work for #158845. Extract the `use_injections` field out of the resolver and into the `LateResolutionVisitor`. It can then be passed into the `report_errors` pass, so no behaviour is changed.

This allows the `Resolver` to be `DynSync`, see #158845 (comment).

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LorrensP-2158466 @rustbot @petrochenkov @eholk