Skip to content

Print a loud error if the configured LLDB cannot be found #159056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Jul 10, 2026
+10 −6
Merged

Print a loud error if the configured LLDB cannot be found #159056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/bootstrap/src/core/debuggers/lldb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,16 @@ pub(crate) fn discover_lldb(builder: &Builder<'_>) -> Option<Lldb> {
// explicit opt-in or configuration.
let lldb_exe = builder.config.lldb.clone().unwrap_or_else(|| PathBuf::from("lldb"));

let lldb_version = command(&lldb_exe)
.allow_failure()
.arg("--version")
.run_capture(builder)
.stdout_if_ok()
.filter(|v| !v.trim().is_empty())?;
let mut cmd = command(&lldb_exe);
cmd.arg("--version");

// If a path to a LLDB binary was provided, it has to exist and return some version, to avoid
// silent failures.
let explicitly_set_lldb = builder.config.lldb.is_some();
if !explicitly_set_lldb {
cmd = cmd.allow_failure();
}
let lldb_version = cmd.run_capture(builder).stdout_if_ok().filter(|v| !v.trim().is_empty())?;

Some(Lldb { lldb_exe, lldb_version })
}
Loading