Pretty-print MIR user types too.#158982
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use Why was this reviewer chosen?The reviewer was selected based on:
|
cjgillot
changed the title
davidtwco
approved these changes
Jul 13, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 13, 2026
…=davidtwco Pretty-print MIR user types too. `ty::UserType` is currently dumped in MIR using debug-printing of types. Unfortunately, this shows the inner index of DefIds, which can change between compilations depending on `cfg` flags. This PR proposes to wire `ty::UserType` into the normal pretty-printing infra, which will give more readable outputs. This also adds a test, as we did not have any mir-opt case featuring non-None `user_self_ty`. Exact formatting to bikeshed.
This was referenced Jul 13, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
Rollup of 11 pull requests Successful merges: - #159210 (`rust-analyzer` subtree update) - #158655 (Fix coroutine MIR saved local remapping) - #159205 (bootstrap: Replace `ShouldRun::crates` with `crate_or_deps_filtered`) - #159208 (Fix `attr_on_non_tail_expr` typo) - #157524 (Fix relative paths in private import suggestions) - #158325 (Document NonNull layout guarantees) - #158882 (enable `do_not_recommend` attr for method call errors in current solver) - #158982 (Pretty-print MIR user types too.) - #159069 (Add codegen test for constant returns after local use) - #159163 (rustc_target: Add acquire-release to implied features of v8) - #159201 (borrowck: Represent 'best blame constraint' as index into `Vec<OutlivesConstraint>`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
Rollup of 11 pull requests Successful merges: - #159210 (`rust-analyzer` subtree update) - #158655 (Fix coroutine MIR saved local remapping) - #159205 (bootstrap: Replace `ShouldRun::crates` with `crate_or_deps_filtered`) - #159208 (Fix `attr_on_non_tail_expr` typo) - #157524 (Fix relative paths in private import suggestions) - #158325 (Document NonNull layout guarantees) - #158882 (enable `do_not_recommend` attr for method call errors in current solver) - #158982 (Pretty-print MIR user types too.) - #159069 (Add codegen test for constant returns after local use) - #159163 (rustc_target: Add acquire-release to implied features of v8) - #159201 (borrowck: Represent 'best blame constraint' as index into `Vec<OutlivesConstraint>`)
rust-timer
added a commit
that referenced
this pull request
Jul 13, 2026
Rollup merge of #158982 - cjgillot:pretty-ascribe-user-ty, r=davidtwco Pretty-print MIR user types too. `ty::UserType` is currently dumped in MIR using debug-printing of types. Unfortunately, this shows the inner index of DefIds, which can change between compilations depending on `cfg` flags. This PR proposes to wire `ty::UserType` into the normal pretty-printing infra, which will give more readable outputs. This also adds a test, as we did not have any mir-opt case featuring non-None `user_self_ty`. Exact formatting to bikeshed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ty::UserTypeis currently dumped in MIR using debug-printing of types. Unfortunately, this shows the inner index of DefIds, which can change between compilations depending oncfgflags.This PR proposes to wire
ty::UserTypeinto the normal pretty-printing infra, which will give more readable outputs. This also adds a test, as we did not have any mir-opt case featuring non-Noneuser_self_ty.Exact formatting to bikeshed.