Skip to content

Bump bootstrap to 1.98 beta#158888

Open
Mark-Simulacrum wants to merge 4 commits into
rust-lang:mainfrom
Mark-Simulacrum:bump-bootstrap
Open

Bump bootstrap to 1.98 beta#158888
Mark-Simulacrum wants to merge 4 commits into
rust-lang:mainfrom
Mark-Simulacrum:bump-bootstrap

Conversation

@Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum commented Jul 7, 2026

Copy link
Copy Markdown
Member

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 7, 2026
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review July 7, 2026 10:47
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

miri is developed in its own repository. If possible, consider making this change to rust-lang/miri instead.

cc @rust-lang/miri

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

Some changes occurred in integer formatting

cc @tgross35

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2026
@rustbot

rustbot commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from Darksonn, JohnTitor, clarfonthey, jhpratt

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
r? me @bors r+ rollup=never

View changes since this review

@rust-bors

rust-bors Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8e98714 has been approved by jieyouxu

It is now in the queue for this repository.

@rustbot rustbot assigned jieyouxu and unassigned JohnTitor Jul 8, 2026
@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@bors p=6

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 9, 2026
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 2d0b8c5 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@JonathanBrouwer

Copy link
Copy Markdown
Contributor
exit code: 0xc0000017, STATUS_NO_MEMORY

Does this reproduce?
@bors try jobs=dist-i686-msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
Bump bootstrap to 1.98 beta


try-job: dist-i686-msvc
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 9, 2026
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=dist-i686-msvc

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
Bump bootstrap to 1.98 beta


try-job: dist-i686-msvc
@rust-bors

rust-bors Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b987108 (b9871087ccc20faddfff11243abe66da32861b61)
Base parent: acf6a00 (acf6a00aff5d8aa8892aadff0b48364b50f97cf4)

@Mark-Simulacrum Mark-Simulacrum force-pushed the bump-bootstrap branch 2 times, most recently from 2180dfb to fa304ef Compare July 11, 2026 20:09
@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=i686

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
Bump bootstrap to 1.98 beta


try-job: *i686*
@rust-bors

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum force-pushed the bump-bootstrap branch 2 times, most recently from 307b08a to 321887a Compare July 11, 2026 20:46
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=i686

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
Bump bootstrap to 1.98 beta


try-job: *i686*
@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

@bors try jobs=i686

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 11, 2026
Bump bootstrap to 1.98 beta


try-job: *i686*
@rust-bors

rust-bors Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8079977 (807997712b96733d92c94e715da474d9128d6dcc)
Base parent: be8e824 (be8e82435eb04fbe75ed5286b52735366e160bed)

@Mark-Simulacrum

Copy link
Copy Markdown
Member Author

OK, so I think if the Cargo side doesn't materialize quickly we can still land (most) of the bootstrap bump here. The last commit (9532156 as of writing) swaps out the Cargo used by CI on i686 Windows builders so we're not affected by the bug (or the fixes).

I'm not sure that's actually worth it, though, and it would break anyone building locally unless they apply a similar change. My sense is we can evaluate that choice over the next week depending on how the Cargo PR progresses.

@weihanglo

Copy link
Copy Markdown
Member

I guess we need this beta bump first? #159182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants