autodiff - typtree cleanups by ZuseZ4 · Pull Request #158278 · rust-lang/rust

ZuseZ4 · 2026-06-23T00:27:17Z

In some recent experiments I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing.

That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted typetree_from_ty_impl and typetree_from_ty_inner, since they don't do much.

r? oli-obk

(noticed a regression in a test, marking as draft for now.)

ZuseZ4 · 2026-06-23T08:12:20Z

Ok, the test was failing on main, regardless of the refactoring. Slightly concerning, but I'll fix it along with the logic updates in the follow-up pr.

ZuseZ4 · 2026-06-23T15:23:08Z

@bors review

rust-bors · 2026-06-23T15:23:11Z

Unknown command "review". Run @bors help or go to https://bors.rust-lang.org/help to see available commands.

oli-obk

@bors r+ rollup

View changes since this review

rust-bors · 2026-06-24T15:09:40Z

📌 Commit d9038db has been approved by oli-obk

It is now in the queue for this repository.

…i-obk autodiff - typtree cleanups In [some recent experiments](https://github.com/rust-lang/rust/pull/157994/changes) I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing. That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted `typetree_from_ty_impl` and `typetree_from_ty_inner`, since they don't do much. r? oli-obk (noticed a regression in a test, marking as draft for now.)

…uwer Rollup of 17 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #158294 (Use .drectve for MSVC DLL exports) - #158253 (codegen_ssa: multiply scalable vec size by `vscale`) - #158308 (Fix bug when rustdoc "go to only result" setting is not working as expected") - #158345 (Use `transmute_neo` in `assume_init`) - #158369 (std: abort when `resume_unwind` is called inside the panic hook) - #158374 (disallow tail calling extern "rust-call" functions) - #158380 (Revert "rebuild LLVM when `bootstrap.toml` config changes") - #154398 (Add test for async Send with PhantomData<*mut ()> + unsafe impl Send + dyn Trait) - #157181 (autodiff: stop always needing an alloca) - #158278 (autodiff - typtree cleanups) - #158311 (doc(unstable-book): fix typo "earier" -> "earlier" in default-visibility flag) - #158318 (Make normalization in a test case resilient to dist compilation) - #158338 (Reorganize `tests/ui/issues` [14/N]) - #158343 (Include `Item::const_stability` info in rustdoc JSON.) - #158355 (Fixup the refactoring errors in #156246) - #158390 (Fix: auto trait, const trait bound) Failed merges: - #155535 (export symbols: support macos/windows(32/64))

…i-obk autodiff - typtree cleanups In [some recent experiments](https://github.com/rust-lang/rust/pull/157994/changes) I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing. That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted `typetree_from_ty_impl` and `typetree_from_ty_inner`, since they don't do much. r? oli-obk (noticed a regression in a test, marking as draft for now.)

…uwer Rollup of 17 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #155535 (export symbols: support macos/windows(32/64)) - #158253 (codegen_ssa: multiply scalable vec size by `vscale`) - #158308 (Fix bug when rustdoc "go to only result" setting is not working as expected") - #158345 (Use `transmute_neo` in `assume_init`) - #158369 (std: abort when `resume_unwind` is called inside the panic hook) - #158374 (disallow tail calling extern "rust-call" functions) - #158380 (Revert "rebuild LLVM when `bootstrap.toml` config changes") - #154398 (Add test for async Send with PhantomData<*mut ()> + unsafe impl Send + dyn Trait) - #157181 (autodiff: stop always needing an alloca) - #158278 (autodiff - typtree cleanups) - #158311 (doc(unstable-book): fix typo "earier" -> "earlier" in default-visibility flag) - #158318 (Make normalization in a test case resilient to dist compilation) - #158338 (Reorganize `tests/ui/issues` [14/N]) - #158343 (Include `Item::const_stability` info in rustdoc JSON.) - #158355 (Fixup the refactoring errors in #156246) - #158390 (Fix: auto trait, const trait bound)

…i-obk autodiff - typtree cleanups In [some recent experiments](https://github.com/rust-lang/rust/pull/157994/changes) I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing. That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted `typetree_from_ty_impl` and `typetree_from_ty_inner`, since they don't do much. r? oli-obk (noticed a regression in a test, marking as draft for now.)

…uwer Rollup of 16 pull requests Successful merges: - #153697 (Add arg splat experiment initial tuple impl) - #155535 (export symbols: support macos/windows(32/64)) - #158253 (codegen_ssa: multiply scalable vec size by `vscale`) - #158308 (Fix bug when rustdoc "go to only result" setting is not working as expected") - #158345 (Use `transmute_neo` in `assume_init`) - #158369 (std: abort when `resume_unwind` is called inside the panic hook) - #158374 (disallow tail calling extern "rust-call" functions) - #158380 (Revert "rebuild LLVM when `bootstrap.toml` config changes") - #154398 (Add test for async Send with PhantomData<*mut ()> + unsafe impl Send + dyn Trait) - #157181 (autodiff: stop always needing an alloca) - #158278 (autodiff - typtree cleanups) - #158311 (doc(unstable-book): fix typo "earier" -> "earlier" in default-visibility flag) - #158318 (Make normalization in a test case resilient to dist compilation) - #158338 (Reorganize `tests/ui/issues` [14/N]) - #158343 (Include `Item::const_stability` info in rustdoc JSON.) - #158390 (Fix: auto trait, const trait bound) Failed merges: - #158355 (Fixup the refactoring errors in #156246)

…uwer Rollup of 15 pull requests Successful merges: - #155535 (export symbols: support macos/windows(32/64)) - #158253 (codegen_ssa: multiply scalable vec size by `vscale`) - #158308 (Fix bug when rustdoc "go to only result" setting is not working as expected") - #158345 (Use `transmute_neo` in `assume_init`) - #158369 (std: abort when `resume_unwind` is called inside the panic hook) - #158374 (disallow tail calling extern "rust-call" functions) - #158380 (Revert "rebuild LLVM when `bootstrap.toml` config changes") - #154398 (Add test for async Send with PhantomData<*mut ()> + unsafe impl Send + dyn Trait) - #157181 (autodiff: stop always needing an alloca) - #158278 (autodiff - typtree cleanups) - #158311 (doc(unstable-book): fix typo "earier" -> "earlier" in default-visibility flag) - #158318 (Make normalization in a test case resilient to dist compilation) - #158338 (Reorganize `tests/ui/issues` [14/N]) - #158343 (Include `Item::const_stability` info in rustdoc JSON.) - #158390 (Fix: auto trait, const trait bound)

Rollup merge of #158278 - ZuseZ4:typetrees-for-enzyme2, r=oli-obk autodiff - typtree cleanups In [some recent experiments](https://github.com/rust-lang/rust/pull/157994/changes) I managed to lower more MIR information to LLVM to help Enzyme compile a test case that was previously failing. That PR became a little bigger, and we might want to add even more code. To get started I split it out of mod.rs, since that file is already 2.4k loc. In the process, I also fix some checks and deleted `typetree_from_ty_impl` and `typetree_from_ty_inner`, since they don't do much. r? oli-obk (noticed a regression in a test, marking as draft for now.)

move typetree logic into a new file

b9d55eb

ZuseZ4 added the F-autodiff `#![feature(autodiff)]` label Jun 23, 2026

rustbot assigned oli-obk Jun 23, 2026

ZuseZ4 marked this pull request as draft June 23, 2026 00:34

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2026

This comment has been minimized.

Sign in to view

ZuseZ4 force-pushed the typetrees-for-enzyme2 branch from 81fe112 to 8698ac6 Compare June 23, 2026 08:07

ZuseZ4 marked this pull request as ready for review June 23, 2026 08:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2026

oli-obk reviewed Jun 23, 2026

View reviewed changes

Comment thread compiler/rustc_middle/src/ty/typetree.rs Outdated

oli-obk reviewed Jun 23, 2026

View reviewed changes

Comment thread compiler/rustc_middle/src/ty/typetree.rs Outdated

oli-obk requested changes Jun 23, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2026

simplify call chains, fix assertions

d9038db

ZuseZ4 force-pushed the typetrees-for-enzyme2 branch from 8698ac6 to d9038db Compare June 23, 2026 15:20

ZuseZ4 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2026

ZuseZ4 mentioned this pull request Jun 23, 2026

Fix typetree generation for differentiated functions #158333

Draft

oli-obk approved these changes Jun 24, 2026

View reviewed changes

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 24, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2026

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 18 pull requests #158386

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 17 pull requests #158389

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 17 pull requests #158391

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 17 pull requests #158395

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 16 pull requests #158413

Closed

JonathanBrouwer mentioned this pull request Jun 25, 2026

Rollup of 15 pull requests #158416

Merged

rust-bors Bot merged commit d6acc46 into rust-lang:main Jun 25, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 25, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

autodiff - typtree cleanups#158278

autodiff - typtree cleanups#158278
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
ZuseZ4:typetrees-for-enzyme2

ZuseZ4 commented Jun 23, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

ZuseZ4 commented Jun 23, 2026

Uh oh!

Uh oh!

Uh oh!

ZuseZ4 commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

oli-obk left a comment •

edited by rustbot

Loading

Uh oh!

rust-bors Bot commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

ZuseZ4 commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ZuseZ4 commented Jun 23, 2026

Uh oh!

Uh oh!

Uh oh!

ZuseZ4 commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

oli-obk left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Jun 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZuseZ4 commented Jun 23, 2026 •

edited

Loading

oli-obk left a comment •

edited by rustbot

Loading