Simplify HardwiredLints and SoftLints#158006
Merged
rust-bors[bot] merged 2 commits intoJun 17, 2026
Merged
Conversation
To get a `LintVec` for a lint pass we sometimes use `get_lints` and sometimes use `lint_vec`. It would be nice to only have one, but doing that is tricky. In the meantime, this commit makes the naming more consistent. - By always using the name `get_lints` for the methods that take `self`. - By always using the name `lint_vec` for the methods that have no parameters.
These are both types that impl `LintPass` but in a degenerate way: only the `lint_vec` method is ever used. This commit changes them to just be a `lint_vec` function in an appropriately-named module. The commit also removes the use of `HardwiredLints` in `late_lint_crate`, which had no effect because all the `HardwiredLints::check_*` methods were no-ops.
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…, r=<try> Simplify `HardwiredLints` and `SoftLints`
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
Finished benchmarking commit (5ecf8cd): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 0.4%, secondary 3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 523.093s -> 532.431s (1.79%) |
rustbot
removed
the
S-waiting-on-perf
Urgau
approved these changes
Jun 17, 2026
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…uwer Rollup of 6 pull requests Successful merges: - #157816 (make more slice mutable ref getters rustc_no_writable) - #156788 (Document that destructors in running threads are not run on program exit) - #157957 (Add documentation for the `must_use` attribute) - #158006 (Simplify `HardwiredLints` and `SoftLints`) - #158007 (Pin dependencies) - #158025 (Enable `symbol_intern_string_literal` lint for rustdoc)
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 18, 2026
…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#157816 (make more slice mutable ref getters rustc_no_writable) - rust-lang/rust#156788 (Document that destructors in running threads are not run on program exit) - rust-lang/rust#157957 (Add documentation for the `must_use` attribute) - rust-lang/rust#158006 (Simplify `HardwiredLints` and `SoftLints`) - rust-lang/rust#158007 (Pin dependencies) - rust-lang/rust#158025 (Enable `symbol_intern_string_literal` lint for rustdoc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in individual commits.
r? @Urgau