Deny partial -Z stack-protector by default in all editions#157941
Open
arielb1 wants to merge 1 commit into
Open
Deny partial -Z stack-protector by default in all editions#157941arielb1 wants to merge 1 commit into
-Z stack-protector by default in all editions#157941arielb1 wants to merge 1 commit into
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
arielb1
force-pushed
the
deny-partial-stack-protector
branch
from
cffa608 to
1a9ed85
Compare
This comment has been minimized.
This comment has been minimized.
arielb1
force-pushed
the
deny-partial-stack-protector
branch
from
1a9ed85 to
5e3dc2c
Compare
This comment has been minimized.
This comment has been minimized.
arielb1
force-pushed
the
deny-partial-stack-protector
branch
from
5e3dc2c to
42cf0c9
Compare
This comment has been minimized.
This comment has been minimized.
arielb1
force-pushed
the
deny-partial-stack-protector
branch
from
42cf0c9 to
7312a2c
Compare
Collaborator
|
Some changes occurred in tests/codegen-llvm/stack-protector.rs cc @rust-lang/project-exploit-mitigations, @rcvalle |
This enables RFC 3855 for stack-protector. With this PR, uses of stack-protector that only have it enabled for a subset of the crates within a process need to pass `-Z allow-partial-mitigations=stack-protector` as well. This was not done in issue 149357 to allow for a smooth transition period. cc the stack-protector tracking issue at issue 114903.
arielb1
force-pushed
the
deny-partial-stack-protector
branch
from
7312a2c to
5edba65
Compare
Contributor
|
☔ The latest upstream changes (presumably #159246) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables RFC 3855 for stack-protector. With this PR, uses of stack-protector that only have it enabled for a subset of the crates within a process need to pass
-Z allow-partial-mitigations=stack-protectoras well.This was not done in #149357 to allow for a smooth transition period.
cc the stack-protector tracking issue at #114903.
r? @rcvalle (do we need any special protocol for the breaking change?)