simplify some proc_macro things#157271
Conversation
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
simplify some `proc_macro` things
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (aba743d): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.4%, secondary -5.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.9%, secondary -2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 511.375s -> 517.888s (1.27%) |
This comment has been minimized.
This comment has been minimized.
7f9f32a to
750ea38
Compare
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang#157271 (though it was not a part of it). This looked pretty promising locally.
mark `Encode`, `Decode`, `Mark` impls as `#[inline]` Related to rust-lang/rust#157271 (though it was not a part of it). This looked pretty promising locally.
This comment has been minimized.
This comment has been minimized.
750ea38 to
30004a8
Compare
|
this should be perf-neutral now since all relevant commits either got dropped or moved into their own PRs |
Each commit should be reviewable on its own. Locally, this also resulted in some slightly better perf results.