Skip to content

add c_variadic_experimental_arch feature#155974

Draft
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:c-variadic-experimental-arch
Draft

add c_variadic_experimental_arch feature#155974
folkertdev wants to merge 1 commit intorust-lang:mainfrom
folkertdev:c-variadic-experimental-arch

Conversation

@folkertdev
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev commented Apr 29, 2026

tracking issue: #155973

Based on https://hackmd.io/pIbUgMQuQcGaibJcinOcEw#Stabilize-c-variadic-function-definitions-rust155697, we'll gate niche targets where we don't control the implementation of va_arg, the ABI is unclear, or in general where we're not confident stabilizing the implementation.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 29, 2026
@rust-log-analyzer

This comment has been minimized.

@folkertdev folkertdev force-pushed the c-variadic-experimental-arch branch 2 times, most recently from 531be28 to c5b7925 Compare April 29, 2026 22:02
@joshtriplett
Copy link
Copy Markdown
Member

This looks reasonable to me, based on the discussions in the lang meeting. We can always un-gate any of these targets in the future, when a maintainer of the target takes a close look and makes sure the tests pass.

I think it might be useful to point people to an invocation of ./x test that will capture all the relevant tests. For instance, does ./x test variadic capture all the tests needed to feel confident that a target implements C variadics correctly?

r=me with such a comment added next to the match arm for the unstable targets. (Not next to the match arm for RISC-V ILP32E, that one is unstable for a different reason.)

@bors delegate+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 29, 2026

✌️ @folkertdev, you can now approve this pull request!

If @joshtriplett told you to "r=me" after making some further change, then please make that change and post @bors r=joshtriplett.

View changes since this delegation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants