Rollup of 4 pull requests#155814
Closed
JonathanBrouwer wants to merge 9 commits into
Closed
Conversation
macro_metavar_expr_concat: explain why idents are invalid Recently I've been playing around with `macro_metavar_expr_concat` and in the process wasted more time than I'd have liked on debugging my dodgy idents. This should make that experience much nicer going forward.
…r=Kivooeo ssa_range_prop: use `if let` guards It is a bit cleaner this way r? @dianqk
…ejrs Cleanups to `AttributeExt` r? @mejrs - Makes some functions take `ast::Attribute` instead of `impl AttributeExt` - Remove `deprecation_note` from `AttributeExt`, since the two implementations are basically seperate
…rk-unstable, r=jhpratt,Urgau Remove the incomplete marker from `impl` restrictions Following the discussion on Zulip ([#gsoc > Idea: Implementing impl and mut restrictions @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Idea.3A.20Implementing.20impl.20and.20mut.20restrictions/near/590562763)),this PR removes the incomplete marker from `#[feature(impl_restriction)]`. Tracking issue for restrictions: rust-lang#105077. r? @Urgau cc @jhpratt
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 475e2d8 with merge ad03350... Workflow: https://github.com/rust-lang/rust/actions/runs/24956620533 |
Contributor
Author
|
Stuck |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved due to being closed. Auto build was cancelled due to the PR being closed. Cancelled workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
if letguards #155779 (ssa_range_prop: useif letguards)AttributeExt#155789 (Cleanups toAttributeExt)implrestrictions #155806 (Remove the incomplete marker fromimplrestrictions)r? @ghost
Create a similar rollup