apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets#155453
apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets#155453japaric wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
japaric
force-pushed
the
a53-linux-fix-errata
branch
from
9bafb16 to
a88c30d
Compare
|
@rustbot ping arm Objections to merging this? |
rustbot
added
the
O-Arm
|
Hey ARM Group! This issue has been identified as a good "ARM candidate". cc @adamgemmell @davidtwco @hug-dev @Jamesbarford @joaopaulocarreiro @lqd @raw-bin @Stammark |
as it's done for other AArch64 targets although the linker (GCC) _may_ be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied for example, the Arm GNU toolchain does _not_ enable the errata mitigation by default (checked version: 13.3.Rel1) see issue 118095 for background information cherry-picked from upstream, see rust-lang/rust#155453 for details re-enable the tests for this fix
|
I'm happy with this, I think everything in Jacob's comment on the none target still applies. How would the user override this if they want to? |
as it's done for other AArch64 targets although the linker (GCC) _may_ be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied for example, the Arm GNU toolchain does _not_ enable the errata mitigation by default (checked version: 13.3.Rel1) see issue 118095 for background information
japaric
force-pushed
the
a53-linux-fix-errata
branch
from
a88c30d to
221687a
Compare
they can pass however, according to my testing there seems to be priority issue with this change.
what that all means is that, to let the user opt out of the errata fix, we should use |
|
Sounds good, thank you! |
|
@bors r+ |
rust-bors
Bot
added
S-waiting-on-bors
…wesleywiser apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets as it's done for other AArch64 targets although the linker (GCC) _may_ be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied for example, the Arm GNU toolchain does _not_ enable the errata mitigation by default (checked version: 13.3.Rel1) see rust-lang#118095 for background information
…wesleywiser apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets as it's done for other AArch64 targets although the linker (GCC) _may_ be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied for example, the Arm GNU toolchain does _not_ enable the errata mitigation by default (checked version: 13.3.Rel1) see rust-lang#118095 for background information
…uwer Rollup of 22 pull requests Successful merges: - #154149 (resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities) - #155189 (simd_reduce_min/max: remove float support) - #155453 (apply Cortex-A53 errata 843419 mitigation to the AArch64 Linux targets) - #155562 (Add a missing `GenericTypeVisitable`, and avoid having interner traits for `FnSigKind` and `Abi`) - #155608 (rustc_middle: Implement the `partial_cmp` operation for `DefId`s) - #155721 (When archive format is wrong produce an error instead of ICE) - #155794 (privacy: share effective visibility initialization) - #155832 (c-variadic: more precise compatibility check in const-eval) - #155856 (std_detect: support detecting more features on aarch64 Windows) - #155861 (Suggest `[const] Trait` bounds in more places) - #155899 (`dlltool`: Set the working directory to workaround `--temp-prefix` bug) - #155916 (Update with new LLVM 22 target for `wasm32-wali-linux-musl` target) - #155935 (remap OUT_DIR paths to fix build script path leakage in crate metadata. ) - #155950 (use the new `//@ needs-asm-mnemonic: ret` more) - #155958 (ci(free-disk-space): remove more tools and fix warnings) - #155966 (miri subtree update) - #155711 (bump curl-sys and openssl-sys to support OpenSSL 4.0.x) - #155831 (Add `AcceptContext::expect_key_value`) - #155877 (Avoid misleading return-type note for foreign `Fn` callees) - #155949 (Update `opt_ast_lowering_delayed_lints` query to allow "stealing" lints, allowing to use `FnOnce` instead of `Fn`) - #155951 (Make `FlatMapInPlaceVec` an unsafe trait.) - #155967 (Fix `doc_cfg` feature for extern items)
rust-bors
Bot
added
S-waiting-on-author
|
This pull request was unapproved. This PR was contained in a rollup (#155976), which was unapproved. |
5 participants
as it's done for other AArch64 targets
although the linker (GCC) may be configured to apply the fix by default it's preferred to have rustc pass the flag to the linker to ensure the mitigation is always applied
for example, the Arm GNU toolchain does not enable the errata mitigation by default (checked version: 13.3.Rel1)
see #118095 for background information