Document panic in RangeInclusive::from(legacy::RangeInclusive)

[tbu-]

View all comments

[rustbot]

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: @scottmcm, libs
• @scottmcm, libs expanded to 7 candidates
• Random selection from Mark-Simulacrum, jhpratt, scottmcm

[jhpratt]

Has this been approved by T-libs-api? The panic message clearly says unspecified, so adding this documentation would overrule that.

[tbu-]

If T-libs doesn't want to guarantee this, I can change the wording to "currently panics, may not panic in the future". Or even "may panic".

[fmease]

#155394

[Amanieu]

ping @tbu-, CI is failing. You need to add #![feature(new_range_api_legacy)] to the doc tests or import the old range types from core::ops instead.

[tbu-]

Thanks for the ping, @Amanieu. I somehow forgot about this PR.

[theemathas]

Note: The current status of the PR adds a new stable guarantee that the conversion will panic for an exhausted iterator.

[jhpratt]

Nominating given the implicit stability guarantee.

[joshtriplett]

@rfcbot merge libs-api

[rust-rfcbot]

@joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @the8472

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[jhpratt]

@bors r-

@bors delegate+

[rust-bors]

This pull request was unapproved.

View changes since this unapproval

[rust-bors]

✌️ @tbu-, you can now approve this pull request!

If @jhpratt told you to "r=me" after making some further change, then please make that change and post @bors r=jhpratt.

View changes since this delegation.

[tbu-]

@bors r=jhpratt

[rust-bors]

📌 Commit 48d2671 has been approved by jhpratt

It is now in the queue for this repository.

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  IMAGE: x86_64-gnu-miri
##[endgroup]
    Updating crates.io index
error: failed to get `simd-adler32` as a dependency of package `miniz_oxide v0.8.8`
    ... which satisfies dependency `miniz_oxide = "^0.8.5"` of package `flate2 v1.1.9`
    ... which satisfies dependency `flate2 = "^1.1.9"` of package `citool v0.1.0 (/home/runner/work/rust/rust/src/ci/citool)`

Caused by:
  failed to load source for dependency `simd-adler32`

Caused by:

[theemathas]

@bors retry

[rust-bors]

❗ You can only retry pull requests that are approved and have a previously failed auto build.

Hint: There is currently a pending auto build on this PR. To cancel it, run @bors cancel.

[rust-bors]

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 9m 28s
Pushing 40f92b3 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a774017 (parent) -> 40f92b3 (this PR)

Test differences

Show 32 test diffs

32 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 40f92b37c4f7566de7348cec4d4c2a350da598d5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. i686-gnu-nopt-2: 2h 18m -> 1h 26m (-37.6%)
2. x86_64-msvc-ext1: 2h 11m -> 1h 23m (-36.9%)
3. x86_64-gnu-llvm-21-2: 1h 33m -> 1h (-35.0%)
4. dist-i686-mingw: 2h 1m -> 2h 37m (+30.3%)
5. x86_64-gnu-gcc: 1h 5m -> 47m 6s (-28.4%)
6. dist-arm-linux-musl: 1h 19m -> 1h 37m (+23.2%)
7. dist-i686-linux: 1h 46m -> 1h 28m (-16.6%)
8. dist-android: 24m 1s -> 27m 57s (+16.4%)
9. aarch64-apple-macos-26: 2h 25m -> 2h 45m (+14.1%)
10. dist-apple-various: 1h 46m -> 1h 59m (+11.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (40f92b3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -4.0%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-4.0%	[-5.9%, -2.0%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.0%	[-5.9%, -2.0%]	2

Cycles

Results (secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.3%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 482.353s -> 479.892s (-0.51%)
Artifact size: 390.76 MiB -> 390.75 MiB (-0.00%)