Some small nits for supertrait_item_shadowing, and additional testing#155172
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Apr 15, 2026
Merged
Some small nits for supertrait_item_shadowing, and additional testing#155172rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
jackh726
commented
Apr 11, 2026
Comment on lines
+26
to
+27
| //[off_normal,off_shadowing]~^ WARN a method with this name may be added | ||
| //[off_normal,off_shadowing]~| WARN once this associated item is added |
Member
Author
There was a problem hiding this comment.
So, looking at this, we may want to not lint when shadowing is enabled. Though, maybe we do, because behavior will change.
lcnr
reviewed
Apr 13, 2026
Member
Author
|
@lcnr indeed that would be better imo. But this was the style that errs used for the rest of these tests. I'm happy to add a new commit that changes the entire set of tests for this feature to use asserts. |
Contributor
|
would be happy about this, yeah |
jackh726
added
S-waiting-on-author
Member
Author
|
Done. |
Contributor
|
thx @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
…nup, r=lcnr Some small nits for supertrait_item_shadowing, and additional testing cc rust-lang#89151 r? types
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
…nup, r=lcnr Some small nits for supertrait_item_shadowing, and additional testing cc rust-lang#89151 r? types
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…uwer Rollup of 9 pull requests Successful merges: - #153536 (Add `const_param_ty_unchecked` gate) - #153815 (Fix ICE when Self is used in enum discriminant of a generic enum) - #154882 (Gate tuple const params behind `min_adt_const_params` feature) - #155293 (fix arch names in cfg pretty printer) - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc) - #155172 (Some small nits for supertrait_item_shadowing, and additional testing) - #155279 (Test/lexer unicode pattern white space) - #155280 (Tests for precise-capture through RPIT and TAIT) - #155304 (remove PointeeParser)
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Rollup of 13 pull requests Successful merges: - #154882 (Gate tuple const params behind `min_adt_const_params` feature) - #155259 (explicit-tail-calls: disable two tests on LoongArch) - #155293 (fix arch names in cfg pretty printer) - #155314 (`BorrowedBuf`: Update outdated safety comments in `set_init` users.) - #153469 (docs: clarify path search behavior in std::process::Command::new) - #154765 (Clarify ascii whitespace exclusion of vertical tab in the doc) - #155172 (Some small nits for supertrait_item_shadowing, and additional testing) - #155279 (Test/lexer unicode pattern white space) - #155280 (Tests for precise-capture through RPIT and TAIT) - #155301 (Delete unused `rustc_trait_selection` errors.) - #155303 (remove ibraheemdev from review rotation) - #155304 (remove PointeeParser) - #155319 (Remove dead diagnostic structs.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #89151
r? types