refactor RangeFromIter overflow-checks impl by pitaj · Pull Request #154191 · rust-lang/rust

pitaj · 2026-03-21T23:21:47Z

Crates with different overflow-checks settings accessing the same RangeFromIter resulted in incorrect values being yielded

Fixes #154124

r? @tgross35

rustbot · 2026-03-21T23:21:53Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

tests/codegen-llvm/fromrangeiter-overflow-checks.rs

tests/ui/iterators/rangefrom-overflow-2crates.rs

tgross35 · 2026-03-22T17:45:52Z

tests/ui/iterators/rangefrom-overflow-2crates.rs

+
+        // let a_next_ocno = next_ocno(&mut a.clone());
+        // let a_next_ocyes = next_ocyes(&mut a);
+        // let b_next_ocyes = next_ocyes(&mut b.clone());
+        // let b_next_ocno = next_ocno(&mut b);
+
+        // assert_eq!(n, a_next_ocno);
+        // assert_eq!(a_next_ocno, a_next_ocyes);
+        // assert_eq!(n, b_next_ocyes);
+        // assert_eq!(b_next_ocyes, b_next_ocno);
+
+
+        // assert_eq!(next_ocno(&mut a.clone()), next_ocyes(&mut a));
+        // assert_eq!(next_ocyes(&mut b.clone()), next_ocno(&mut b));


This can be removed

Knew I was going to forget about this 🤦‍♂️

tgross35 · 2026-03-22T17:49:34Z

tests/ui/iterators/rangefrom-overflow-2crates.rs

+    // `b` should have wrapped
+    assert_eq!(0, next_ocyes(&mut b.clone()));
+    assert_eq!(0, next_ocno(&mut b));
+    // `a` should be exhausted,
+    // which will wrap when called without overflow-checks
+    assert_eq!(0, next_ocno(&mut a.clone()));
+    // and panic when called with overflow-checks
+    let r = std::panic::catch_unwind(move || {


(optional nit) Maybe give a and b names like next_with_oc and next_without_oc? It's a bit tricky to follow

tgross35 · 2026-03-22T17:50:23Z

Checking what I said in #154191 (comment)

@bors try jobs=x86_64-gnu-nopt

Cc issue author @theemathas

rust-bors · 2026-03-22T17:50:27Z

⌛ Trying commit e173b53 with merge e81a45d…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/23408886027

refactor RangeFromIter overflow-checks impl try-job: x86_64-gnu-nopt

tgross35 · 2026-03-22T18:01:58Z

@bors try cancel

rust-bors · 2026-03-22T18:02:02Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/23408886027

tgross35

r=me with the two items that weren't resolved by me rereading test headers

View changes since this review

Crates with different overflow-checks settings accessing the same RangeFromIter resulted in incorrect values being yielded

tgross35 · 2026-03-22T19:54:48Z

@bors r+

rust-bors · 2026-03-22T19:54:52Z

📌 Commit 8befc9d has been approved by tgross35

It is now in the queue for this repository.

@tgross35

refactor RangeFromIter overflow-checks impl Crates with different overflow-checks settings accessing the same RangeFromIter resulted in incorrect values being yielded Fixes rust-lang#154124 r? @tgross35

@tgross35

refactor RangeFromIter overflow-checks impl Crates with different overflow-checks settings accessing the same RangeFromIter resulted in incorrect values being yielded Fixes rust-lang#154124 r? @tgross35

…uwer Rollup of 13 pull requests Successful merges: - #154241 (`rust-analyzer` subtree update) - #153686 (`std`: include `dlmalloc` for all non-wasi Wasm targets) - #154105 (bootstrap: Pass `--features=rustc` to rustc_transmute) - #153069 ([BPF] add target feature allows-misaligned-mem-access) - #154085 (Parenthesize or-patterns in prefix pattern positions in pretty printer) - #154191 (refactor RangeFromIter overflow-checks impl) - #154207 (Refactor query loading) - #153540 (drop derive helpers during attribute parsing) - #154140 (Document consteval behavior of ub_checks, overflow_checks, is_val_statically_known.) - #154161 (On E0277 tweak help when single type impls traits) - #154218 (interpret/validity: remove unreachable error kind) - #154225 (diagnostics: avoid ICE in confusable_method_name for associated functions) - #154228 (Improve inline assembly error messages)

…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#154241 (`rust-analyzer` subtree update) - rust-lang/rust#153686 (`std`: include `dlmalloc` for all non-wasi Wasm targets) - rust-lang/rust#154105 (bootstrap: Pass `--features=rustc` to rustc_transmute) - rust-lang/rust#153069 ([BPF] add target feature allows-misaligned-mem-access) - rust-lang/rust#154085 (Parenthesize or-patterns in prefix pattern positions in pretty printer) - rust-lang/rust#154191 (refactor RangeFromIter overflow-checks impl) - rust-lang/rust#154207 (Refactor query loading) - rust-lang/rust#153540 (drop derive helpers during attribute parsing) - rust-lang/rust#154140 (Document consteval behavior of ub_checks, overflow_checks, is_val_statically_known.) - rust-lang/rust#154161 (On E0277 tweak help when single type impls traits) - rust-lang/rust#154218 (interpret/validity: remove unreachable error kind) - rust-lang/rust#154225 (diagnostics: avoid ICE in confusable_method_name for associated functions) - rust-lang/rust#154228 (Improve inline assembly error messages)

rustbot assigned tgross35 Mar 21, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 21, 2026

tgross35 reviewed Mar 22, 2026

View reviewed changes

rust-bors bot pushed a commit that referenced this pull request Mar 22, 2026

Auto merge of #154191 - pitaj:fix-154124, r=<try>

e81a45d

refactor RangeFromIter overflow-checks impl try-job: x86_64-gnu-nopt

tgross35 approved these changes Mar 22, 2026

View reviewed changes

tgross35 mentioned this pull request Mar 22, 2026

stabilize new RangeFrom type and iterator #153380

Open

refactor RangeFromIter overflow-checks impl

8befc9d

Crates with different overflow-checks settings accessing the same RangeFromIter resulted in incorrect values being yielded

pitaj force-pushed the fix-154124 branch from e173b53 to 8befc9d Compare March 22, 2026 19:32

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2026

JonathanBrouwer mentioned this pull request Mar 23, 2026

Rollup of 10 pull requests #154240

Closed

This was referenced Mar 23, 2026

Rollup of 13 pull requests #154242

Closed

Rollup of 13 pull requests #154253

Merged

rust-bors bot merged commit 61b4c77 into rust-lang:main Mar 23, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 23, 2026

Uh oh!

Conversation

pitaj commented Mar 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 21, 2026

Uh oh!

Uh oh!

Uh oh!

tgross35 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

pitaj Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Mar 22, 2026

Uh oh!

rust-bors bot commented Mar 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pitaj commented Mar 21, 2026 •

edited by rustbot

Loading

rust-bors bot commented Mar 22, 2026 •

edited

Loading

tgross35 left a comment •

edited by rustbot

Loading