Skip to content

deny-by-default & report in deps uninhabited_static#152853

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WaffleLapkin:deny_uninhabited_static
Apr 6, 2026
Merged

deny-by-default & report in deps uninhabited_static#152853
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
WaffleLapkin:deny_uninhabited_static

Conversation

@WaffleLapkin
Copy link
Copy Markdown
Member

@WaffleLapkin WaffleLapkin commented Feb 19, 2026 •
edited by rustbot
Loading

View all comments

The lint was introduced as a FCW in #78324 and landed in rust 1.49.0 (5 years ago); see also #74840.

Per the discussion in #149518 (comment).

cc @fmease @scottmcm @traviscross

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 19, 2026

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 15 candidates

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the deny_uninhabited_static branch from b5caed3 to 8bf6c59 Compare February 19, 2026 14:11
@traviscross traviscross added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Feb 19, 2026
@chenyukang
Copy link
Copy Markdown
Member

chenyukang commented Feb 24, 2026

@bors r=chenyukang

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 24, 2026

📌 Commit 8bf6c59 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2026
@chenyukang
Copy link
Copy Markdown
Member

chenyukang commented Feb 24, 2026

seems need the decision from language team.
@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2026
@theemathas theemathas added S-waiting-on-t-lang Status: Awaiting decision from T-lang and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2026
@scottmcm
Copy link
Copy Markdown
Member

scottmcm commented Feb 25, 2026

Since it's still just a lint, I'd be fine to accept this under meeting consensus. (Hopefully we'll discuss it today.)

@traviscross
Copy link
Copy Markdown
Contributor

traviscross commented Feb 25, 2026

We talked about this in the meeting today. Makes sense. Let's propose to do it.

@rfcbot fcp merge lang

@rust-rfcbot
Copy link
Copy Markdown
Collaborator

rust-rfcbot commented Feb 25, 2026 •
edited by scottmcm
Loading

Team member @traviscross has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Feb 25, 2026
@rust-rfcbot
Copy link
Copy Markdown
Collaborator

rust-rfcbot commented Feb 25, 2026

🔔 This is now entering its final comment period, as per the review above. 🔔

@traviscross traviscross removed I-lang-nominated Nominated for discussion during a lang team meeting. P-lang-drag-1 Lang team prioritization drag level 1. https://rust-lang.zulipchat.com/#narrow/channel/410516-t-lang labels Feb 28, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@WaffleLapkin WaffleLapkin force-pushed the deny_uninhabited_static branch from 4c83028 to 008fda0 Compare April 2, 2026 08:48
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@WaffleLapkin

This comment was marked as off-topic.

Sign in to view
@rustbot

This comment was marked as off-topic.

Sign in to view
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Apr 2, 2026

@rustbot reroll

@rustbot rustbot assigned jieyouxu and unassigned chenyukang Apr 2, 2026
ehuss
ehuss reviewed Apr 2, 2026
View reviewed changes
Comment thread compiler/rustc_lint_defs/src/builtin.rs
@jieyouxu jieyouxu removed the S-waiting-on-t-lang Status: Awaiting decision from T-lang label Apr 5, 2026
jieyouxu
jieyouxu reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Need to fix a --stage=2 doctest bootstrap/not-bootstrap gating, then r=me and chenyukang.
@rustbot author

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026
@WaffleLapkin WaffleLapkin force-pushed the deny_uninhabited_static branch from 008fda0 to 9b1f20d Compare April 5, 2026 18:37
@WaffleLapkin

This comment was marked as off-topic.

Sign in to view
@rust-bors

This comment was marked as off-topic.

Sign in to view
@WaffleLapkin
Copy link
Copy Markdown
Member Author

WaffleLapkin commented Apr 5, 2026

@bors r=jieyouxu,chenyukang

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 5, 2026

📌 Commit 9b1f20d has been approved by jieyouxu,chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2026
@jhpratt jhpratt mentioned this pull request Apr 6, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Apr 6, 2026
@bors
Auto merge of #154862 - jhpratt:rollup-mjtl7mx, r=jhpratt
c2efcc4 
Rollup of 4 pull requests

Successful merges:

 - #152853 (deny-by-default & report in deps `uninhabited_static`)
 - #153615 (fixed generics of crate node ICE)
 - #154744 (Remove `Clone` impl for `StableHashingContext`.)
 - #154841 (add regression test for Redundant memory strores with mut parameters …)
@rust-bors rust-bors bot merged commit 892d08c into rust-lang:main Apr 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 6, 2026
rust-timer added a commit that referenced this pull request Apr 6, 2026
@rust-timer
Unrolled build for #152853
c16892a 
Rollup merge of #152853 - WaffleLapkin:deny_uninhabited_static, r=jieyouxu,chenyukang

deny-by-default & report in deps `uninhabited_static`

The lint was introduced as a FCW in #78324 and landed in rust 1.49.0 (5 years ago); see also #74840.

Per the discussion in #149518 (comment).

cc @fmease @scottmcm @traviscross
@WaffleLapkin WaffleLapkin deleted the deny_uninhabited_static branch April 6, 2026 14:33
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Apr 7, 2026
@bors
Auto merge of #154862 - jhpratt:rollup-mjtl7mx, r=jhpratt
9940865 
Rollup of 4 pull requests

Successful merges:

 - rust-lang/rust#152853 (deny-by-default & report in deps `uninhabited_static`)
 - rust-lang/rust#153615 (fixed generics of crate node ICE)
 - rust-lang/rust#154744 (Remove `Clone` impl for `StableHashingContext`.)
 - rust-lang/rust#154841 (add regression test for Redundant memory strores with mut parameters …)
@ehuss ehuss mentioned this pull request Apr 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehuss ehuss ehuss left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jieyouxu jieyouxu

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-lang-radar Items that are on lang's radar and will need eventual work or consideration. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team to-announce Announce this issue on triage meeting

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

10 participants

@WaffleLapkin @rustbot @rust-log-analyzer @chenyukang @scottmcm @traviscross @rust-rfcbot @ehuss @jieyouxu @theemathas