add back LLVM-specific funnel shift implementation#149391
add back LLVM-specific funnel shift implementation#149391RalfJung wants to merge 1 commit intorust-lang:mainfrom
Conversation
This reverts commit a00db66.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
add back LLVM-specific funnel shift implementation
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (be9fa2b): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -2.4%, secondary 0.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.335s -> 472.107s (0.38%) |
|
So this does actually help a bit but only for a synthetic benchmark... doesn't seem worth it. |
This reverts commit a00db66. That commit is likely the culprit for the unexpected perf regression in #148478; let's see if reverting it helps.