Skip to content

Temporarily bring back Rvalue::Len#135709

Merged
bors merged 4 commits intorust-lang:masterfrom
lqd:bring-back-len
Jan 19, 2025
Merged

Temporarily bring back Rvalue::Len#135709
bors merged 4 commits intorust-lang:masterfrom
lqd:bring-back-len

Conversation

@lqd
Copy link
Copy Markdown
Member

@lqd lqd commented Jan 18, 2025

r? @compiler-errors as requested in #135671 (comment)

However, in the mean time, I'd rather we not crunch trying to find and more importantly validate the soundness of a solution 🤔

Agreed. To fix the IMO P-critical #135671 for which we somehow didn't have test coverage, this PR temporarily reverts:

cc @scottmcm

I added the few samples from that issue as a test, but we can add more in the future, in particular it seems @steffahn will work on that.

Fixes #135671. And if we want to land this, it should also be nominated for beta backport.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

regression: cannot borrow ... as immutable because it is also borrowed as mutable