Replace zero-width whitespace with a visible \ in the PR template#131151
Replace zero-width whitespace with a visible \ in the PR template#131151bors merged 1 commit intorust-lang:masterfrom
\ in the PR template#131151Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
| This PR will get automatically assigned to a reviewer. In case you would like | ||
| a specific user to review your work, you can assign it to them by using | ||
|
|
||
| r? <reviewer name> |
There was a problem hiding this comment.
This is actually
r⌴? <reviewer name>
Can check with tools like https://www.dcode.fr/zero-width-space. This was initially added so the r/? in the template itself doesn't trigger rustbot, but it unintentionally makes it very confusing if someone tried to reuse this exact string.
fmease
left a comment
fmease
left a comment
There was a problem hiding this comment.
one suggestion but otherwise r=me
People tried to copy the `r?` which had an invisible zero-width whitespace, causing rustbot to not recognize the instruction, and which makes it difficult to figure out why it didn't work.
jieyouxu
force-pushed
the
adjust-pr-template
branch
from
04cac15 to
aa3251d
Compare
jieyouxu
changed the title
/ in the PR template\ in the PR template
bors
added
S-waiting-on-bors
|
Testing that \ actually works and doesn't get erased by a markdown parser before rustbot gets the chance to look at it: r? fmease |
|
Wait a second, that also doesn't render visually? At least, one r/? fmease Or even r⌴? fmease to make it really obvious, lol. |
|
Yeah, fair enough. I'm fine with / or ␣ then. I was worried that the string "r/?" looked so alien and might lead to a "what the f_ck" moment for new contributors. @bors r- |
bors
added
S-waiting-on-author
|
Not sure why we'd need it to be visually rendered. The comment won't appear in the PR description anyways, and anyone that tries to copy from a rendered, escaped r? ghost would still copy the correct way to do it IIUC. |
bors
added
S-waiting-on-bors
|
We can also change triagebot to ignore html comments if that helps. |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#130863 (Relax a debug assertion for dyn principal *equality* in codegen) - rust-lang#131016 (Apple: Do not specify an SDK version in `rlib` object files) - rust-lang#131140 (Handle `rustc_hir_analysis` cases of `potential_query_instability` lint) - rust-lang#131141 (mpmc doctest: make sure main thread waits for child threads) - rust-lang#131150 (only query `params_in_repr` if def kind is adt) - rust-lang#131151 (Replace zero-width whitespace with a visible `\` in the PR template) - rust-lang#131152 (Improve const traits diagnostics for new desugaring) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#131151 - jieyouxu:adjust-pr-template, r=fmease Replace zero-width whitespace with a visible `\` in the PR template People (incl. myself) tried to copy the `r?` which had an invisible zero-width whitespace (meaning it was actually more like `r⌴?`), causing rustbot to not recognize the instruction, and which makes it difficult to figure out why it didn't work. This PR replaces the zero-width whitespace with a visible `\` alongside a comment to remove the `\`. It's a bit less "visual", but at least it's visible why the rustbot assignment doesn't work.
7 participants
People (incl. myself) tried to copy the
r?which had an invisible zero-width whitespace (meaning it was actually more liker⌴?), causing rustbot to not recognize the instruction, and which makes it difficult to figure out why it didn't work.This PR replaces the zero-width whitespace with a visible
\alongside a comment to remove the\. It's a bit less "visual", but at least it's visible why the rustbot assignment doesn't work.