Add stable Instance::body() and RustcInternal trait by celinval · Pull Request #116964 · rust-lang/rust

celinval · 2023-10-20T00:16:01Z

The Instance::body() returns a monomorphized body.

For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal.

Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed.

The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first.

r? @oli-obk

The `Instance::body()` returns a monomorphized body. For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal. Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed.

rustbot · 2023-10-20T00:16:10Z

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

oli-obk · 2023-10-20T15:18:19Z

@bors r+ rollup

bors · 2023-10-20T15:18:21Z

📌 Commit 6ed2a76 has been approved by oli-obk

It is now in the queue for this repository.

oli-obk · 2023-10-20T15:19:28Z

As discussed in the smir meeting, we'll land this and then refactor away most of the need for the smir::Ty -> rustc::Ty conversion. We are still landing this to keep around the logic for doing the conversion, as we want to support the "mutating the MIR" use case in the future

oli-obk · 2023-10-20T15:41:56Z

@bors r+

bors · 2023-10-20T15:41:57Z

📌 Commit 6e643e1 has been approved by oli-obk

It is now in the queue for this repository.

Add stable Instance::body() and RustcInternal trait The `Instance::body()` returns a monomorphized body. For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal. Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed. The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first. r? `@oli-obk`

Add stable Instance::body() and RustcInternal trait The `Instance::body()` returns a monomorphized body. For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal. Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed. The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first. r? ``@oli-obk``

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#116911 (Suggest relaxing implicit `type Assoc: Sized;` bound) - rust-lang#116961 (Typo suggestion to change bindings with leading underscore) - rust-lang#116964 (Add stable Instance::body() and RustcInternal trait) - rust-lang#116992 (Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist) - rust-lang#116995 (Point at assoc fn definition on type param divergence) Failed merges: - rust-lang#116974 (coverage: Fix inconsistent handling of function signature spans) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114521 (std: freebsd build update.) - rust-lang#116911 (Suggest relaxing implicit `type Assoc: Sized;` bound) - rust-lang#116917 (coverage: Simplify the injection of coverage statements) - rust-lang#116961 (Typo suggestion to change bindings with leading underscore) - rust-lang#116964 (Add stable Instance::body() and RustcInternal trait) - rust-lang#116974 (coverage: Fix inconsistent handling of function signature spans) - rust-lang#116990 (Mention `into_iter` on borrow errors suggestions when appropriate) - rust-lang#116995 (Point at assoc fn definition on type param divergence) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116964 - celinval:smir-mono-body, r=oli-obk Add stable Instance::body() and RustcInternal trait The `Instance::body()` returns a monomorphized body. For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal. Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed. The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first. r? ```@oli-obk```

rustbot assigned oli-obk Oct 20, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2023

celinval commented Oct 20, 2023

View reviewed changes

Comment thread compiler/stable_mir/src/ty.rs Outdated

Remove obsolete comment

6e643e1

matthiaskrgr mentioned this pull request Oct 20, 2023

Rollup of 4 pull requests #116994

Closed

matthiaskrgr mentioned this pull request Oct 20, 2023

Rollup of 5 pull requests #117002

Closed

matthiaskrgr mentioned this pull request Oct 21, 2023

Rollup of 8 pull requests #117013

Merged

bors merged commit b703519 into rust-lang:master Oct 21, 2023

rustbot added this to the 1.75.0 milestone Oct 21, 2023

celinval mentioned this pull request Oct 25, 2023

Add a conversion method for going from smir::Ty to rustc::Ty rust-lang/project-stable-mir#46

Closed

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add stable Instance::body() and RustcInternal trait#116964

Add stable Instance::body() and RustcInternal trait#116964
bors merged 2 commits intorust-lang:masterfrom
celinval:smir-mono-body

celinval commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

bors commented Oct 20, 2023

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

bors commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

celinval commented Oct 20, 2023

Uh oh!

rustbot commented Oct 20, 2023

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

bors commented Oct 20, 2023

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

Uh oh!

oli-obk commented Oct 20, 2023

Uh oh!

bors commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants