Merged
Conversation
This fixes a regression introduced in 3d57b24.
…ching) Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Contributor
There was a problem hiding this comment.
The variable might be moved still, but it wasn't correct to link to move-expressions.
Fixes rust-lang#11559 (not that the manual couldn't use a review).
Contributor
Author
|
@cmr Adressed. |
bors
added a commit
that referenced
this pull request
Jan 18, 2014
Noticeably necroes #10892. Also closes #11559. r? @alexcrichton
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 21, 2023
Fix ice in `redundant_locals` Fixes rust-lang#11619 Rebinding over macro like the code below, idents will be different (`x#4` and `x#0` in that case). ```rust fn reassign_in_macro() { let x = 10; macro_rules! mac { ($i:ident) => { let mut x = x; } } mac!(y); } ``` It causes unwrapping `None`. https://github.com/rust-lang/rust-clippy/blob/9554e477c29e6ddca9e5cdce71524341ef9d48e8/clippy_lints/src/redundant_locals.rs#L88-L98 changelog: ICE: [`redundant_locals`]: No longer lints rebinding over macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticeably necroes #10892.
Also closes #11559.
r? @alexcrichton