Introduce a Stable trait to translate MIR to SMIR#112600
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 14, 2023
Merged
Introduce a Stable trait to translate MIR to SMIR#112600bors merged 1 commit intorust-lang:masterfrom
Stable trait to translate MIR to SMIR#112600bors merged 1 commit intorust-lang:masterfrom
Conversation
I was wondering if this would be a bit cleaner.
rustbot
added
S-waiting-on-review
Collaborator
Contributor
|
Oh yea, this is much better! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112584 (loongarch64-none*: Remove environment component from llvm target) - rust-lang#112600 (Introduce a `Stable` trait to translate MIR to SMIR) - rust-lang#112605 (Improve docs/clean up negative overlap functions) - rust-lang#112611 (Error on unconstrained lifetime in RPITIT) - rust-lang#112612 (Fix explicit-outlives-requirements lint span) - rust-lang#112613 (Fix rustdoc-gui tests on Windows) - rust-lang#112620 (Fix small typo) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a trait
Stablewhich defines a typeTand astable()method to convert the current type to its stable MIR version.This change is just an implementation detail, and I wanted to get some feedback to whether it would be cleaner than having the
rustc_<type>_to_<type>()methods for every type we translate to SMIR.r? @oli-obk
r? @spastorino