csky targets' atomic RMW is not lock-free

[taiki-e]

In csky, LLVM always generates libcalls (llvm/llvm-project@ec2de74), and atomic implementations are provided by libatomic.

rust/compiler/rustc_target/src/spec/csky_unknown_linux_gnuabiv2.rs

Line 15 in c7224e3

late_link_args_static: TargetOptions::link_args(LinkerFlavor::Gnu(Cc::Yes, Lld::No), &["-l:libatomic.a"]),

However, as mentioned in #115577 (comment), the atomic RMW implementation provided in libatomic.a is not lock-free.

And it violates what the standard library is intended to guarantee.

https://doc.rust-lang.org/nightly/std/sync/atomic/index.html#portability

All atomic types in this module are guaranteed to be lock-free if they’re available. This means they don’t internally acquire a global mutex.

Also, mixing lock-free load/store and non-lock-free RMW can cause data races.

To fix this, we would need to do one of the following:

• Fix libatomic to make the RMW implementation lock-free.
• Fix LLVM to generate atomic instructions instead of libcalls.

It is not impossible to fix this on our end, but it is not very realistic as it would require writing a lot of inline assembly.

cc @Dirreke (mentioned because you are target maintainer)

---

@rustbot label +A-atomic +I-unsound

[Dirreke]

Thanks!

I think to fix LLVM to generate atomic instructions instead of libcalls is a better idea.

The linux system and the gcc-toolchain of csky is not well maintained and the newest version of them is not open-source. Besides, there's many exsited devices with the system which is not suitable for upgrade.

Therefore, I think to fix LLVM is a more realizable and practical way.

[bjorn3]

(We don't have a CSky target label?)

[RalfJung]

I assume this is about the csky-unknown-linux-gnuabiv2 target.

[Dirreke]

I assume this is about the csky-unknown-linux-gnuabiv2 target.

and the csky-unknown-linux-gnuabiv2hf

[apiraino]

WG-prioritization assigning priority (Zulip discussion).

@Dirreke AFAICS the compiler target csky-unknown-linux-gnuabiv2hf is not mapped on our Tier support list. Do you think it should be updated?

@rustbot label -I-prioritize +P-low

[Dirreke]

@Dirreke AFAICS the compiler target csky-unknown-linux-gnuabiv2hf is not mapped on our Tier support list. Do you think it should be updated?

csky-unknown-linux-gnuabiv2hf is introduced into rust at #117049 . The target csky-unknown-linux-gnuabiv2hf and the related docs will be released in the next version.