remove dependency on reverted const type id#419
Merged
Conversation
|
Is this perhaps the expected error to find on 1.47? |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
(cargo-release) version 0.2.2 Co-authored-by: github-actions <github-actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were going to depend on
const_type_id, but that feature was reverted before it was stabilized.I'm working on a refactoring that changes this, but in the meantime anybody depending on
kv_unstableand building on1.47.0is broken. This just removes the expectation that1.47.0will allowconst_type_id.