l4re: update definitions and test infra - #5275
Merged
Merged
Conversation
JohnTitor
approved these changes
Jul 11, 2026
This was referenced Jul 11, 2026
Contributor
Author
|
Nice, thanks for the quick review and merge! Are there by any chance plans to make a new release soon? |
Contributor
|
I'm planning on a new release in the next couple of days |
tgross35
added
the
stable-nominated
tgross35
reviewed
Jul 20, 2026
Comment on lines
+6388
to
+6389
| #if defined(__linux__) && defined(__has_include) | ||
| #if __has_include(<linux/version.h>) |
Contributor
There was a problem hiding this comment.
Does l4re define __linux__? Or what's the reason for this change?
Contributor
Author
There was a problem hiding this comment.
It's a bit more complicated. We use the linux gcc for compiling for l4re (which means we configure/parametrize it to link to our own libs, to use the l4re loader etc.). Therefore, __linux__ is set in this case because it's a linux-gcc but we don't use it as such.
Contributor
There was a problem hiding this comment.
Thanks for the clarification. Is there a definition like __l4re__ that winds up set? And/or a way to check the l4re version?
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
(backport <rust-lang#5275>) (cherry picked from commit 6094fee)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
(backport <rust-lang#5275>) (cherry picked from commit 6094fee)
Merged
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
(backport <rust-lang#5275>) (cherry picked from commit 6094fee)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jul 20, 2026
(backport <rust-lang#5275>) (cherry picked from commit 6094fee)
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The definitions in l4re have changed, mostly due to uclibc being updated and uclibc config having changed. Also, this makes the test infrastructure work for l4re again.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI