Add ucontext_t for aarch64-unknown-linux-musl#1863
Add ucontext_t for aarch64-unknown-linux-musl#1863JohnTitor merged 1 commit intorust-lang:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
1ca768f to
eb618e2
Compare
Did you test with this workaround? I guess we could auto-derive it here as well... libc/src/unix/linux_like/linux/gnu/b64/aarch64/align.rs Lines 25 to 27 in 035a480 |
I tried it but the math doesn't work out in this case. The prime factorization of |
|
Ah, makes sense. I'd still prefer to auto-derive it as this will make the difference between arch/env and users will be confused. |
|
(Note that CI will fail anyway until #1865 gets merged.) |
|
Looks good except for spurious failures. Could you rebase and squash commits into one? |
e385d17 to
2259b0b
Compare
|
@JohnTitor squashed! |
See: bytecodealliance/wasmtime#2133