Merged
Conversation
Member
Author
|
Hmm, getting some errors that look unrelated. |
Member
|
The *xc/*xf files are for 80-bit floats, which only exist on x86/x86_64, except on Android and MSVC targets. These files not not be included for aarch64 targets. |
Member
|
I believe the compilation error has been addressed by #568. |
Contributor
|
I verified that after this PR is merged, it's possible to build dist-aarch64-linux with LLVM 18. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 26, 2024
Update to LLVM 18 Blocked on rust-lang#120376. Blocked on rust-lang/compiler-builtins#564. LLVM 18 final is planned to be released on Mar 5th. Rust 1.77 is planned to be released on Mar 21st. Tested images: dist-x86_64-linux, dist-s390x-linux, dist-aarch64-linux, dist-riscv64-linux, dist-x86_64-freebsd, dist-x86_64-illumos x86_64-linux-integration, test-various, armhf-gnu r? `@ghost`
Contributor
|
@Amanieu Could you please merge this PR and create a new compiler-builtins release with it? |
Member
|
I can't merge the PR since it is still marked as a draft. @tmandry Is there anything left to do for this PR? |
Contributor
|
Would it help if I open a new non-draft PR for the change? |
This happened in https://github.com/llvm/llvm-project/pull/75635/files and shows up when building against a recent commit of LLVM.
e402868 to
4e5c34b
Compare
Member
|
Actually I just realized that I can do it myself. |
Member
|
@nikic Published in 0.1.107. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened in https://github.com/llvm/llvm-project/pull/75635/files
and shows up when building against a recent commit of LLVM.