Implement with_hasher adaptors#1007
Conversation
jswrenn
left a comment
There was a problem hiding this comment.
One small nit, but otherwise this LGTM.
|
Two nits:
@jswrenn Feel free to proceed as you deem appropriate. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
- Coverage 94.38% 93.86% -0.53%
==========================================
Files 48 51 +3
Lines 6665 6633 -32
==========================================
- Hits 6291 6226 -65
- Misses 374 407 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It would be a breaking change for Rust to change its default hasher, so we're fine to rely on |
|
@424ever Are you planning to continue with this PR? |
Sorry for the late reply. Yes, I'll rebase this and clean it up a bit |
|
Do I need to do something about the failing semver checks? Those aren't in any files this PR touches. |
|
@phimuemue @jswrenn Can we get this in for 0.15? |
The semver check failure is informational, and expected because there are changes to the public API. |
Yeah, sure! :) |
Closes #998
Implementations for the following methods: