Skip to content

serial: Replace the serial-rs crate with serialport-rs - #89

Merged
bors[bot] merged 2 commits into
rust-embedded:masterfrom
qrasmont:86-use-serialport-rs
Mar 20, 2023
Merged

serial: Replace the serial-rs crate with serialport-rs#89
bors[bot] merged 2 commits into
rust-embedded:masterfrom
qrasmont:86-use-serialport-rs

Conversation

@qrasmont

Copy link
Copy Markdown
Contributor

Replace the unmaintained serial-rs crate with serialport-rs.
Closes #86

@eldruin eldruin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Could you add the libudev-dev package here and also add an entry to the changelog?

@qrasmont
qrasmont force-pushed the 86-use-serialport-rs branch from 9e0d092 to 31a5cf1 Compare March 18, 2023 14:41
@qrasmont

Copy link
Copy Markdown
Contributor Author

Thank you! Could you add the libudev-dev package here and also add an entry to the changelog?

I chose to remove the dependency to libudev-sys (by disabling default features for the serialport-rs crate) because cross compilation would rely on a pkg-config config with a sysroot for the target (see readme) which complicates the setup for CI and usage.
Especially since as described here, the impact of disabling this dependency sums up as : "Enumeration will still be available [...], but won't expose as much information and may return ports that don't exist physically."

This would not be necessary if this PR got merged into libudev-sys: dcuddeback/libudev-sys#8

@qrasmont
qrasmont marked this pull request as ready for review March 19, 2023 13:52
@qrasmont
qrasmont requested a review from a team as a code owner March 19, 2023 13:52

@eldruin eldruin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution. Thank you for looking into it.
Sadly libudev-sys seems abandoned, but great to know that it is not really necessary.

Comment thread CHANGELOG.md Outdated

@eldruin eldruin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for your work!
bors r+

@bors

bors Bot commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

@bors
bors Bot merged commit 1f97fd4 into rust-embedded:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serial-unix crate is unmaintained

2 participants