Filter and normalise json output for golden test runs#24
Merged
Conversation
jberthold
approved these changes
Jan 15, 2025
jberthold
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Have to check what happened to the test workflow...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to filter and normalise the json output when comparing output to the golden tests. Some cases when we want to normalise output:
"NormalSym"mangled function names will have a hash following17hthat will change when the compiler version changes."symbol_name"mangled function names will have a hash following17hthat will change when the compiler version changes.