Skip to content

update smir_pretty submodule to latest master#434

Merged
jberthold merged 5 commits into
masterfrom
update-smir-pretty-submodule
Jan 23, 2025
Merged

update smir_pretty submodule to latest master#434
jberthold merged 5 commits into
masterfrom
update-smir-pretty-submodule

Conversation

@jberthold

Copy link
Copy Markdown
Collaborator

No description provided.

@jberthold

Copy link
Copy Markdown
Collaborator Author

Saw one warning message locally:

kmir/src/tests/integration/data/run-rs/memory/box.rs: Items missing static with id StaticDef(DefId { id: 36, name: "alloc::alloc::__rust_no_alloc_shim_is_unstable" }) and name "__rust_no_alloc_shim_is_unstable"

It seems the smir-pretty conversion succeeds nevertheless and the program can be parsed, but I will check what exactly is happening there.

@jberthold jberthold marked this pull request as ready for review January 22, 2025 22:14
@dkcumming

Copy link
Copy Markdown
Collaborator

Saw one warning message locally:

kmir/src/tests/integration/data/run-rs/memory/box.rs: Items missing static with id StaticDef(DefId { id: 36, name: "alloc::alloc::__rust_no_alloc_shim_is_unstable" }) and name "__rust_no_alloc_shim_is_unstable"

It seems the smir-pretty conversion succeeds nevertheless and the program can be parsed, but I will check what exactly is happening there.

This is related to runtimeverification/stable-mir-json#29 which is from merging the PR that removed our Rust fork and switched to the beta fork.

@dkcumming dkcumming left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jberthold jberthold merged commit a60bb24 into master Jan 23, 2025
@jberthold jberthold deleted the update-smir-pretty-submodule branch January 23, 2025 00:55
Stevengre pushed a commit that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants