fix: Clear CodeTeams::Plugin registries when busting caches#12
Merged
alexevanczuk merged 2 commits intorubyatscale:mainfrom Jul 12, 2023
Merged
Conversation
alexevanczuk
approved these changes
Jul 12, 2023
Contributor
alexevanczuk
left a comment
alexevanczuk
left a comment
There was a problem hiding this comment.
This looks great! Want to increment the patch version so CD will automatically publish a new version once we merge?
lib/code_teams/plugin.rb
Outdated
|
|
||
| sig { void } | ||
| def self.bust_caches! | ||
| all_plugins.each { _1.clear_team_registry! } |
Contributor
There was a problem hiding this comment.
Haven't seen this syntax before! I'm used to each(&:clear_team_registry!)
Contributor
Author
There was a problem hiding this comment.
ha, yeah not sure why I used that syntax here 😵 Changed it to the more terse &: version.
This ensures stale team configs are purged when calling CodeTeams.bust_caches!
jordanbyron
force-pushed
the
patch-jtb/bust-plugin-cache
branch
from
cb83620 to
b326ef0
Compare
Contributor
Author
All set! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all! I stubbed my toe on this while writing tests that manipulated team configs. This ensures stale team configs are purged when calling
CodeTeams.bust_caches!Let me know if you have any concerns with this approach or would like different / additional testing.