Skip to content

Include license in gem#41

Merged
kou merged 1 commit intoruby:masterfrom
marvinthepa:include_license
May 13, 2022
Merged

Include license in gem#41
kou merged 1 commit intoruby:masterfrom
marvinthepa:include_license

Conversation

@marvinthepa
Copy link
Copy Markdown
Contributor

why?

1. Redistributions of source code must retain the above copyright
   notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
   notice, this list of conditions and the following disclaimer in the
   documentation and/or other materials provided with the distribution.

AFAIK, a gem is a redistribution of source code and/or binary formats, so it should include the license. Also makes it easier for users of the gem to compile a list of all licenses they use.

@kou
Copy link
Copy Markdown
Member

kou commented May 13, 2022

Good catch!
Could you also add COPYING?

@marvinthepa
Copy link
Copy Markdown
Contributor Author

marvinthepa commented May 13, 2022

Could you also add COPYING?

With the greatest pleasure.

Copying seems to contain a two contradictions, though:

  • it is copyrighted to Minero Aoki, while LICENSE.txt is copyrighted to Yukihiro Matsumoto
  • it mentions the file BDSL, which does not exist (should probably refer to LICENSE.txt, as this contains the mentioned 2-clause BSD license)

I do not feel like I should fix these issues, so I will just add the file.

@kou
Copy link
Copy Markdown
Member

kou commented May 13, 2022

OK. I'll merge this as is.

@kou kou merged commit d2f1db0 into ruby:master May 13, 2022
@kou
Copy link
Copy Markdown
Member

kou commented May 13, 2022

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants