Implement chomp: option for gets, readline, readlines, each_line#503
Implement chomp: option for gets, readline, readlines, each_line#503casperisfine wants to merge 1 commit intoruby:masterfrom
chomp: option for gets, readline, readlines, each_line#503Conversation
|
Seems fine. |
25a3d18 to
cafde8e
Compare
|
Thanks for working on this! This is indeed overlooked and should be implemented. Unlike
I think that should be aligned with IO too, as these currently don't give any useful return value. |
cafde8e to
be4c942
Compare
um, so we'd need to chomp whatever the regexp matched? Seems tricky. |
…line` It was added to IO methods in Ruby 2.4, but OpenSSL sockets don't have them, so any code accepting SSL sockets can't make use of it. Ref: ruby/ruby@a2144bd
be4c942 to
e4f3a2a
Compare
It was added to IO methods in Ruby 2.4, but OpenSSL sockets don't have
them, so any code accepting SSL sockets can't make use of it.
Ref: ruby/ruby@a2144bd
cc @nobu since you implemented this in
IO.On another note, this led me to notice that
SSLSocket#gets(nil)andSSLSocket#gets("")aren't supported either.