Conversation
This looks like it was added for debugging, but it's unassigned and unused now. Future debuggers can easily add it back as needed.
There is _some_ value in testing that it works even without this change. But the main purpose of the test is simply testing the conversion from a hash parameter. Forcing the kwargs to be empty is fine. Other than backports, maybe, this is the last ruby 2.7 concession I'll be making before we raise the minimum ruby requirement. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other than backports, maybe, these should be the last ruby 2.7 workarounds we need to make before raising the minimum ruby requirement to 3.1 (#276).