Skip to content

Skip chown tests when the target group is not assignable #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takano32 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip chown tests when the target group is not assignable #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion test/fileutils/test_fileutils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,32 @@ def have_file_perm?
/mswin|mingw|bcc|emx/ !~ RUBY_PLATFORM
end

@@assignable_groups = nil

# Filter the given group IDs down to those the current process can actually
# assign to a file with chown. Some environments (e.g. user-namespace
# containers) report supplementary groups such as the overflow GID
# (65534/nobody) that the kernel refuses to chgrp to; without this the
# group-ownership tests would fail with EPERM instead of being skipped.
def assignable_groups(groups)
@@assignable_groups ||= {}
groups.select do |gid|
@@assignable_groups.fetch(gid) do
Dir.mktmpdir("fileutils") do |dir|
probe = File.join(dir, "probe")
File.write(probe, "")
@@assignable_groups[gid] =
begin
File.chown(nil, gid, probe)
true
rescue Errno::EPERM
false
end
end
end
end
end

@@have_symlink = nil

def have_symlink?
Expand Down Expand Up @@ -182,7 +208,7 @@ def mymkdir(path)

def setup
@prevdir = Dir.pwd
@groups = [Process.gid] | Process.groups if have_file_perm?
@groups = assignable_groups([Process.gid] | Process.groups) if have_file_perm?
tmproot = @tmproot = Dir.mktmpdir "fileutils"
Dir.chdir tmproot
my_rm_rf 'data'; mymkdir 'data'
Expand Down
Loading