Fix arguments for ::Process::daemon patch#905
Merged
ko1 merged 3 commits intoruby:masterfrom Mar 7, 2023
Merged
Conversation
As discussed here: ruby@699a31e#r94469355
829d0d3 to
429cbf6
Compare
andyw8
commented
Feb 22, 2023
| <<~'RUBY' | ||
| 1| trap(:HUP, 'IGNORE') | ||
| 2| puts 'Daemon starting' | ||
| 3| Process.daemon(false, false) |
Contributor
Author
There was a problem hiding this comment.
|
Thank you. This is terrific. |
andyw8
commented
Feb 22, 2023
| # When manualy debugging a daemon, it doesn't receive SIGHUP. | ||
| # I don't know why. | ||
| <<~'RUBY' | ||
| program = <<~'RUBY' |
Contributor
Author
There was a problem hiding this comment.
I changed this to match the pattern already in use elsewhere.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here:
699a31e#r94469355
The following repo demonstrates the problem:
https://github.com/andyw8/replicate-debug-daemon-patch-issue
In this branch, the Gemfile is updated to point to this PR:
https://github.com/andyw8/replicate-debug-daemon-patch-issue/tree/andyw8/fix-process-daemon-patch: