🔊 Make INFO the default logging level#752
Closed
marianosimone wants to merge 1 commit intoruby:masterfrom
marianosimone:marianosimone/make_info_default
Closed
🔊 Make INFO the default logging level#752marianosimone wants to merge 1 commit intoruby:masterfrom marianosimone:marianosimone/make_info_default
marianosimone wants to merge 1 commit intoruby:masterfrom
marianosimone:marianosimone/make_info_default
Conversation
ko1
reviewed
Sep 16, 2022
Collaborator
|
Thank you for the patch.
I agree 1 and 3 is INFO and DEBUG. Not sure for 2. Your patch makes 2 as DEBUG (and I agree almost it is enough). The current design
is better? Let me take a time for consideration. |
Contributor
Author
|
I think Feel free to edit this PR as you see fit to match your logging philosophy, though :) |
Collaborator
|
fix with #823 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As proposed by @ko1 in #750, make
INFOthe default level, so we can move down some messages like:At the same time, there seem to be a lot of current logs that are more suited for the
DEBUGlevel thanINFO, so I'm moving those down to not make the new default more noisy.