Fix remote client configuration#675
Merged
peterzhu2118 merged 2 commits intoruby:masterfrom Jul 4, 2022
Merged
Conversation
mode is not an actual configuration option, it's only used to carry the result of parse_argv to exe/rdbg's case statement. Having it in the config hash will cause confusion and make `CONFIG.set_config(config)` fail.
st0012
force-pushed
the
fix-remote-client-configuration
branch
from
c136bb2 to
82f7192
Compare
`update` replaces the hash directly and can drop the populated default values, while `set_config` keeps the value `CONFIG` already has and only sets the differences.
st0012
force-pushed
the
fix-remote-client-configuration
branch
from
82f7192 to
021a1ea
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a leftover issue caused by #642
When a remote debugger client is started, it doesn't have configurations filled like the debuggee does, which can cause some issues. Like:
This is because
CONFIG.updatereplaces the entire config hash and removes all the default valuesCONFIGalready has. So if we start a client withrdbg -A, this will happen:config = DEBUGGER__::Config::parse_argv(ARGV)returns a hash like{ mode: :attach }.modeisn't a real configuration option. It's only used to pass the mode information from the-Aflag.CONFIGwill be initialized with all the default configuration values.{:mode=>:start, :log_level=>:WARN, :show_src_lines=>10, :show_frames=>2, :use_short_path=>false, .....}CONFIG.updatewill replace the hash in 2 with the{ mode: :attach }.