Protocol test framework improvements#654
Merged
peterzhu2118 merged 4 commits intoruby:masterfrom Jun 24, 2022
Merged
Conversation
a105e13 to
dbfaee9
Compare
dbfaee9 to
0c2234b
Compare
The default timeout is 6 hours, which is unnecessarily long. We should stop tests if it doesn't finish in 10~15 mins to see what happens.
0c2234b to
ab55aaf
Compare
Member
Author
|
@peterzhu2118 I could also use your help on this test improvement. You can run protocol tests with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes when debugging Ruby head's hanging issue and they did make the build failures easier to catch.
WebSocketClient#cleanupto#closebecause that's all it does