Unify frame and locals collection implementation between ThreadClient and servers#465
Conversation
|
Could you wait for refactoring CDP part until I'm done creating the test framework for CDP? |
|
@ono-max I can drop the changes for CDP server if you concern about the test coverage. |
|
That sounds good. Could you drop it? Thank you. |
cd1ccb4 to
dccd0c1
Compare
|
@ono-max done 👍 |
|
why dap tests are changed? |
|
Could you rebase this PR so that we can confirm if your changes work in CI? |
dccd0c1 to
bcba6ea
Compare
|
@ono-max rebased and it passed 👍 |
|
Sorry, if you're ok, could you use the test generator instead of modifying tests directly to rewrite tests? |
1572ccf to
5d4e33c
Compare
This change also fixes an issue that '%self' is not displayed when stepping backward.
5d4e33c to
34463a8
Compare
|
Did you fix tests with the test generator? |
|
No. I plan to use the new |
|
Sorry for absent. I'll merge it and I revisit to consider about the name |
|
@ko1 thank you 🙏 |
get_frameto retrieve frames with the given frame index.collect_localsto retrieve the locals from the given frame.%selfisn't displayed in DAP when stepping backward.Thanks to the DAP tests written by @ono-max, I feel a lot comfortable doing such refactoring now 👍