Expect escaped backslashes in expressions to inspect#68
Merged
os97673 merged 6 commits intoruby-debug:masterfrom Mar 6, 2015
Merged
Expect escaped backslashes in expressions to inspect#68os97673 merged 6 commits intoruby-debug:masterfrom
os97673 merged 6 commits intoruby-debug:masterfrom
Conversation
lib/ruby-debug-ide/command.rb
Outdated
Member
There was a problem hiding this comment.
the code doesn't work for 1.8.7 :(
lib/ruby-debug-ide/command.rb
Outdated
Member
There was a problem hiding this comment.
I'm not sure this type of continuation is allowed in 1.8
Please double-check.
Fix expression_info for ruby 1.8
Member
There was a problem hiding this comment.
I'd replace code from L18 till L30 with
set_io_encoding(io, string_to_parse.encoding) if string_to_parse.respond_to?(:encoding)
this way the code will be a little bit more clear.
What do you think?
os97673
added a commit
that referenced
this pull request
Mar 6, 2015
Expect escaped backslashes in expressions to inspect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way to differ newline (
\n) from escaped (\\n) since backslashes are not escaped. I propose to escape backslashes when querying ruby-debug-ide and expect these escapes while parsing input.