feat(rewrite): #2721 prepend rtk for TOML filters invoked via binary paths.#2722
Open
denis-peshkov wants to merge 11 commits into
Open
feat(rewrite): #2721 prepend rtk for TOML filters invoked via binary paths.#2722denis-peshkov wants to merge 11 commits into
denis-peshkov wants to merge 11 commits into
Conversation
denis-peshkov
changed the title
rtk for commands like node_modules/.bin/make that match built-in TOML filters but have no rules.rs prefix entry.
denis-peshkov
force-pushed
the
feat/toml-path-rewrite-fallback
branch
from
June 30, 2026 13:09
234ed90 to
3ed8f0a
Compare
kimi-cli has no .kimirules convention — that file is never read. It loads project instructions from AGENTS.md (same as Codex). Rewrite run_kimi_mode to inject the RTK instructions block into AGENTS.md via write_rtk_block, and thread InitContext through to match the other agent modes. - run_kimi_mode/run_kimi_mode_at now take InitContext (was verbose: u8) - remove dead .kimirules write path - drop duplicate run_codex_mode left by an earlier merge conflict - main.rs: call run_kimi_mode(ctx); remove spurious run_antigravity_mode - delete embedded hooks/kimi/rules.md (no longer used) - tests assert AGENTS.md is written and .kimirules is never created
4 tasks
…ike `node_modules/.bin/make` that match built-in TOML filters but have no `rules.rs` prefix entry. Closes rtk-ai#2721 ## Why `run_fallback` already resolves basename for TOML lookup; `rtk rewrite` did not. Path invocations were never rewritten → no token savings in Cursor/Claude agents. ## Changes - `lookup_command_for_filter()` in `toml_filter.rs` - TOML-match fallback in `registry.rs::rewrite_segment_inner()` - Tests using existing `make` built-in filter
denis-peshkov
force-pushed
the
feat/toml-path-rewrite-fallback
branch
from
July 10, 2026 04:46
3ed8f0a to
4b0ef69
Compare
feat(hook): add support for Kimi AI agent
…ike `node_modules/.bin/make` that match built-in TOML filters but have no `rules.rs` prefix entry. Closes rtk-ai#2721 ## Why `run_fallback` already resolves basename for TOML lookup; `rtk rewrite` did not. Path invocations were never rewritten → no token savings in Cursor/Claude agents. ## Changes - `lookup_command_for_filter()` in `toml_filter.rs` - TOML-match fallback in `registry.rs::rewrite_segment_inner()` - Tests using existing `make` built-in filter
… into feat/toml-path-rewrite-fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TOML-aware rewrite fallback so hooks prepend
rtkfor commands likenode_modules/.bin/makethat match built-in TOML filters but have norules.rsprefix entry.After #2719
Closes #2721
Why
run_fallbackalready resolves basename for TOML lookup;rtk rewritedid not. Path invocations were never rewritten → no token savings in Cursor/Claude agents.Changes
lookup_command_for_filter()intoml_filter.rsregistry.rs::rewrite_segment_inner()makebuilt-in filter